lib: nrf_modem: trace: remove deprecated backends and other updates #15353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemrey
requested review from
eivindj-nordic,
rlubos,
a team and
carlescufi
as code owners
lemrey
requested review from
balaji-nordic and
bjda
and removed request for
a team
github-actions
bot
added
the
doc-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
divipillai
reviewed
May 21, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
|
|
||
| * Updated: | ||
|
|
||
| * Fixed an issue with the CFUN hooks when the Modem library is initialized during ``SYS_INIT`` at kernel level and makes calls to the :ref:`nrf_modem_at` interface before the application level initialization is done. |
There was a problem hiding this comment.
Fixed needs to be a separate bullet point like Added, updated and removed, after the "updated" entry.
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
divipillai
reviewed
May 21, 2024
Yes, updated now |
divipillai
reviewed
May 21, 2024
| .. toggle:: | ||
|
|
||
| * For applications using :ref:`nrf_modem_lib_readme`: | ||
| The option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR` is now deprecated. Use the option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART` instead. |
There was a problem hiding this comment.
Suggested change
| The option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR` is now deprecated. Use the option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART` instead. | |
| The option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR` is now deprecated. | |
| Use the option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART` instead. |
| @@ -753,7 +753,10 @@ Modem libraries | |||
|
|
|||
| * :ref:`nrf_modem_lib_readme`: | |||
|
|
|||
| * Added the Kconfig option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_CHUNK_SZ` to process traces in chunks. This can improve the availability of trace memory, and thus reduce the chances of losing traces. | |||
There was a problem hiding this comment.
Suggested change
| * Added the Kconfig option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_CHUNK_SZ` to process traces in chunks. This can improve the availability of trace memory, and thus reduce the chances of losing traces. | |
| * Added the Kconfig option :kconfig:option:`CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_CHUNK_SZ` to process traces in chunks. | |
| This can improve the availability of trace memory, and thus reduce the chances of losing traces. |
lemrey
force-pushed
the
trace-updates
branch
2 times, most recently
from
c1cfe0c
to
ca6d212
Compare
divipillai
approved these changes
May 22, 2024
Fix build warnings when any of the following were defined: - CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_BITRATE - CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_BITRATE_LOG - CONFIG_NRF_MODEM_LIB_TRACE_BITRATE_LOG These warnings triggered a crash in the application. Use the correct function to cancel the delayed work item. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART from project config. The trace backend selection is a choice, and the sample is already selecting one of the choices; no point in turning the other off. Signed-off-by: Emanuele Di Santo <[email protected]>
Remove deprecated options: - CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_ASYNC - CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_SYNC After removing the depreacated options, there is only one config left in choice NRF_MODEM_LIB_TRACE_BACKEND_UART_VERSION, and that is NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR. It therefore makes no point to keep the choice altogether. Deprecate the choie config NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR. Signed-off-by: Emanuele Di Santo <[email protected]>
Update log strings. Signed-off-by: Emanuele Di Santo <[email protected]>
Trace data is processed in chunks. Every time a whole chunk of trace data is processed, it is freed from the shared memory. By reducing or tweaing the chunk size, it is possible to free the shared memory more often, albeit by a smaller amount. This, however, can improve the availability of shared memory, thus reducing the chance of losing traces. Signed-off-by: Emanuele Di Santo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf_modem_lib_trace.c