Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_modem: trace: remove deprecated backends and other updates #15353

Merged
merged 5 commits into from
May 27, 2024
Merged

lib: nrf_modem: trace: remove deprecated backends and other updates #15353

merged 5 commits into from
May 27, 2024

Commits on May 24, 2024

  1. lib: nrf_modem: trace: fix build warnings when measuring bitrate 

    Fix build warnings when any of the following were defined:
- CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_BITRATE
- CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_BITRATE_LOG
- CONFIG_NRF_MODEM_LIB_TRACE_BITRATE_LOG

These warnings triggered a crash in the application.
Use the correct function to cancel the delayed work item.

Signed-off-by: Emanuele Di Santo <[email protected]>
    @lemrey
    lemrey committed May 24, 2024
    Configuration menu
    Copy the full SHA
    eaa4c28 View commit details
    Browse the repository at this point in the history

  2. samples: cellular: modem_trace_backend: remove default conf 

    Remove CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART from project config.
The trace backend selection is a choice, and the sample is already
selecting one of the choices; no point in turning the other off.

Signed-off-by: Emanuele Di Santo <[email protected]>
    @lemrey
    lemrey committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6abe648 View commit details
    Browse the repository at this point in the history

  3. lib: nrf_modem: trace: remove deprecated options in choice 

    Remove deprecated options:
- CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_ASYNC
- CONFIG_NRF_MODEM_LIB_TRACE_BACKEND_UART_SYNC

After removing the depreacated options, there is only one
config left in choice NRF_MODEM_LIB_TRACE_BACKEND_UART_VERSION,
and that is NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR.

It therefore makes no point to keep the choice altogether.
Deprecate the choie config NRF_MODEM_LIB_TRACE_BACKEND_UART_ZEPHYR.

Signed-off-by: Emanuele Di Santo <[email protected]>
    @lemrey
    lemrey committed May 24, 2024
    Configuration menu
    Copy the full SHA
    26af3b7 View commit details
    Browse the repository at this point in the history

  4. lib: nrf_modem: trace: uart: update backend logs 

    Update log strings.

Signed-off-by: Emanuele Di Santo <[email protected]>
    @lemrey
    lemrey committed May 24, 2024
    Configuration menu
    Copy the full SHA
    81dec8f View commit details
    Browse the repository at this point in the history

  5. lib: nrf_modem: trace: uart: let traces be processed in chunks 

    Trace data is processed in chunks.
Every time a whole chunk of trace data is processed, it is freed
from the shared memory. By reducing or tweaing the chunk size,
it is possible to free the shared memory more often, albeit by a
smaller amount. This, however, can improve the availability of
shared memory, thus reducing the chance of losing traces.

Signed-off-by: Emanuele Di Santo <[email protected]>
    @lemrey
    lemrey committed May 24, 2024
    Configuration menu
    Copy the full SHA
    eb54e62 View commit details
    Browse the repository at this point in the history