Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snippets: emulate the nRF54L05 and the nRF54L10 RAM and RRAM sizes #18046

Merged
merged 2 commits into from
Oct 23, 2024
Merged

snippets: emulate the nRF54L05 and the nRF54L10 RAM and RRAM sizes #18046

merged 2 commits into from
Oct 23, 2024

Conversation

carlescufi
Copy link
Contributor

Note that this is not compatible with enabling FLPR.

@carlescufi carlescufi requested a review from a team as a code owner October 21, 2024 12:53
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 21, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 21, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 7be2badaa9c7eb9cebacd187c716f45c411832fd

more details

sdk-nrf:

PR head: 7be2badaa9c7eb9cebacd187c716f45c411832fd
merge base: 59470dfab05b6c503391144999573bc3d2c2f409
target head (main): 7d20097408cf11e7763139261423d31c93f05be0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6) 
snippets
│  ├── emulated-nrf54l05
│  │  ├── README.rst
│  │  ├── boards
│  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │ snippet.yml
│  ├── emulated-nrf54l10
│  │  ├── README.rst
│  │  ├── boards
│  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │ snippet.yml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 33
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@carlescufi carlescufi force-pushed the emulate-l05-l10 branch 2 times, most recently from e7c8f36 to 1ab235b Compare October 21, 2024 13:08
@shanthanordic shanthanordic added this to the 2.8.0 milestone Oct 21, 2024
@carlescufi
Copy link
Contributor Author

@masz-nordic addressed your comment.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@carlescufi
Copy link
Contributor Author

@annwoj could you please review this one?

divipillai
divipillai reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A snippet section will be added under nRF54l15 developing with guide in a separate PR. Also , added some suggestions of Anna, which was discussed offline.

snippets/emulated-nrf54l05/README.rst Outdated Show resolved Hide resolved
snippets/emulated-nrf54l05/README.rst Outdated Show resolved Hide resolved
snippets/emulated-nrf54l10/README.rst Outdated Show resolved Hide resolved
snippets/emulated-nrf54l10/README.rst Outdated Show resolved Hide resolved
nordicjm
nordicjm reviewed Oct 22, 2024
View reviewed changes
snippets/emulated-nrf54l10/snippet.yml
name: emulated-nrf54l10

boards:
nrf54l15dk/nrf54l15/cpuapp:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use a wildcard for this so it works on any board with an nrf54l15 but not required

@miha-nordic
Copy link

@carlescufi Why this has milestone 2.8.0? When it was decided to add it to the scope?

@divipillai
Copy link
Contributor

divipillai commented Oct 22, 2024 •
edited
Loading

A snippet section will be added under nRF54l15 developing with guide in a separate PR. Also , added some suggestions of Anna, which was discussed offline.

Created PR #18090 for doc changes.

@carlescufi
snippets: Add snippet to emulate the nRF54L10
fb3686d 
Add a snippet to simulate the RAM and RRAM sizes of the nRF54L10 when
building for the nRF54L15.

Note that enabling FLPR is not supported when using this snippet.

Signed-off-by: Carles Cufi <[email protected]>
@carlescufi
snippets: Add snippet to emulate the nRF54L05
7be2bad 
Add a snippet to simulate the RAM and RRAM sizes of the nRF54L05 when
building for the nRF54L15.

Note that enabling FLPR is not supported when using this snippet.

Signed-off-by: Carles Cufi <[email protected]>
@shanthanordic
Copy link

Manually tested for the following examples
hello_world
bluetooth_peripheral_uart
bluetooth_peripheral_lbs
bluetooth_peripheral_hids_mouse
peripheral_power_profiling

@carlescufi
Copy link
Contributor Author

@carlescufi Why this has milestone 2.8.0? When it was decided to add it to the scope?

Check with @shanthanordic please.

@shanthanordic shanthanordic removed the DNM label Oct 23, 2024
@rlubos rlubos merged commit 0f2cc60 into nrfconnect:main Oct 23, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm approved these changes

@divipillai divipillai divipillai approved these changes

@masz-nordic masz-nordic masz-nordic approved these changes

@gmarull gmarull gmarull approved these changes

@ihansse ihansse ihansse approved these changes

@bjorn-tore-taraldsen bjorn-tore-taraldsen bjorn-tore-taraldsen approved these changes

@wbober wbober wbober approved these changes

@bjarki-andreasen bjarki-andreasen Awaiting requested review from bjarki-andreasen

@anangl anangl Awaiting requested review from anangl

@umapraseeda umapraseeda Awaiting requested review from umapraseeda

@annwoj annwoj Awaiting requested review from annwoj

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.