shard: drop more of context from local stores #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2946 +/- ##
=======================================
Coverage 23.88% 23.88%
=======================================
Files 776 776
Lines 45893 45888 -5
=======================================
Hits 10961 10961
+ Misses 34070 34065 -5
Partials 862 862 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
approved these changes
Sep 23, 2024
carpawell
reviewed
Sep 23, 2024
| @@ -324,7 +323,7 @@ func (e *StorageEngine) isLocked(addr oid.Address) (bool, error) { | |||
| return locked, outErr | |||
| } | |||
|
|
|||
| func (e *StorageEngine) processExpiredObjects(_ context.Context, addrs []oid.Address) { | |||
There was a problem hiding this comment.
tbh, i am not sure it should never be used there. expired object handling can be interrupted, and an expired now object will still be expired in every next epoch, so if we are about to stop working, such operation is safe to stop immediately. however, none of the current "iteration" storage engine operations supports context so ok
Similar to edc447f, we can't have any meaninful context here and current context checks are broken. Fixes #1911, the last case of Error in `cmd/neofs-node/config.go`: `Function `Reload->Init->init->listenEvents` should pass the context parameter`. goes away with this. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
context-unreleased
branch
from
163c154
to
54494ac
Compare
carpawell
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to edc447f, we can't have any meaninful context here and current context checks are broken. Fixes #1911, the last case of
Error in
cmd/neofs-node/config.go:FunctionReload->Init->init->listenEventsshould pass the context parameter.goes away with this.