meta: fix Delete test
#2949
Merged
meta: fix Delete test
#2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 23.88% 23.89%
=======================================
Files 776 776
Lines 45893 45888 -5
=======================================
+ Hits 10961 10963 +2
+ Misses 34070 34064 -6
+ Partials 862 861 -1 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Sep 24, 2024
carpawell
force-pushed
the
fix/meta-delete-test
branch
from
ac6263a
to
7fecaea
Compare
End-rey
reviewed
Sep 24, 2024
Behavior has changed a few times since the original implementation. Also, the test was broken a little in 8107c8d. Parent/child relations were changed and now are treated differently at higher levels, so this test is not so important (see new `TestDeleteAllChildren` below, it plays a more important role in metabase testing), but keeping it in working condition with correct statements is not a bad idea. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/meta-delete-test
branch
from
7fecaea
to
8c2e18d
Compare
End-rey
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior has changed a few times since the original implementation. Also, the test was broken a little in 8107c8d. Parent/child relations were changed and now are treated differently at higher levels, so this test is not so important (see new
TestDeleteAllChildrenbelow, it plays a more important role in metabase testing), but keeping it in working condition with correct statements is not a bad idea.