Create named container from CLI #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2950 +/- ##
==========================================
- Coverage 23.54% 23.53% -0.01%
==========================================
Files 776 776
Lines 46576 46579 +3
==========================================
- Hits 10965 10964 -1
- Misses 34749 34752 +3
- Partials 862 863 +1 ☔ View full report in Codecov by Sentry. |
End-rey
force-pushed
the
2682-create-named-container-from-cli
branch
from
18f6757
to
f0c9ce3
Compare
End-rey
force-pushed
the
2682-create-named-container-from-cli
branch
from
f0c9ce3
to
a1f83e8
Compare
roman-khimov
approved these changes
Sep 24, 2024
carpawell
approved these changes
Sep 24, 2024
|
Some conflicts. |
Flag `--name` now sets also `__NEOFS__NAME` attribute, which is used for container domain name in NNS contracts. Closes #2682. Signed-off-by: Andrey Butusov <[email protected]>
End-rey
force-pushed
the
2682-create-named-container-from-cli
branch
from
a1f83e8
to
6345314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2682.