Skip to content

Commit

Permalink
add docs to feedback model (#1696)
Browse files Browse the repository at this point in the history
  • Loading branch information
lferran authored Jan 2, 2024
1 parent 318ffd1 commit dec39c1
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions nucliadb_models/nucliadb_models/search.py
Original file line number Diff line number Diff line change
Expand Up @@ -890,10 +890,16 @@ class FeedbackTasks(str, Enum):


class FeedbackRequest(BaseModel):
ident: str
good: bool
task: FeedbackTasks
feedback: Optional[str]
ident: str = Field(
title="Request identifier",
description="Id of the request to provide feedback for. This id is returned in the response header `Nuclia-Learning-Id` of the chat endpoint.", # noqa
)
good: bool = Field(title="Good", description="Whether the result was good or not")
task: FeedbackTasks = Field(
title="Task",
description="The task the feedback is for. For now, only `CHAT` task is available",
)
feedback: Optional[str] = Field(title="Feedback", description="Feedback text")


TextBlocks = List[List[str]]
Expand Down

3 comments on commit dec39c1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dec39c1 Previous: 5a633b0 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 12857.932253796413 iter/sec (stddev: 2.894127007684444e-7) 12745.686329086004 iter/sec (stddev: 1.7317806991721728e-7) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dec39c1 Previous: 5a633b0 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13096.845870320747 iter/sec (stddev: 1.8619339795890836e-7) 12745.686329086004 iter/sec (stddev: 1.7317806991721728e-7) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: dec39c1 Previous: 5a633b0 Ratio
nucliadb/search/tests/unit/search/test_fetch.py::test_highligh_error 13176.26975745974 iter/sec (stddev: 0.0000017638635360002078) 12745.686329086004 iter/sec (stddev: 1.7317806991721728e-7) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.