[Fong Yi Fei] iP #282

YiFei2 · 2022-01-28T02:36:07Z

It's Bobby.

Features

Bobby will remember what you tell him.
Bobby can remind you of what you told him.
Bobby can search his memory for something you told him.

What can Bobby remember?

To dos
Deadlines (with date in YYYY-MM-DD format)
Events (with date/time in any format)

Here is how Bobby would encourage you in `taskDone`

public static void taskDone(Task t) {
        System.out.println("Bobby applauds you. This task is done:\n" + t);
    }

An example of what you could do with Bobby.

CS2103 iP tab
CS2106 lab
shower 🚿
CS2102 tutorial

"If you got a dog, feed it everyday. But if you don't, don't."

?

…and cleaned up print statements in Bobby.

…ing no next line

…ceptions and are handled in the main method

…ng for bobby

# Conflicts: # src/main/java/Deadline.java

…inciples

# Conflicts: # src/main/java/bobby/Bobby.java

khoahre123

Look pretty solid, some lines need to change according to the coding standard. Overall, good job 💯

khoahre123 · 2022-02-03T12:42:10Z

src/main/java/bobby/Event.java

+
+    @Override
+    public void writeToFile(FileWriter fw) throws IOException {
+        fw.write("E ; " + isDone + " ; " + description + " ; " + at + System.lineSeparator());


Should the break line be 8 spaces indent compared to the parent line?

khoahre123 · 2022-02-03T12:44:43Z

src/main/java/bobby/Deadline.java

+import java.time.format.DateTimeFormatter;
+
+public class Deadline extends Task {
+    protected LocalDate by;


Maybe another more meaningful name?

khoahre123 · 2022-02-03T12:46:57Z

src/main/java/bobby/Parser.java

+            case DEADLINE:
+                try {
+                    tasks.addDeadline(userInput);
+                } catch (BobbyException e) {


I think you can combine all the expected exceptions into one file and call that instance

khoahre123 · 2022-02-03T12:49:53Z

src/main/java/bobby/TaskList.java

+                String description = splitInputs[0];
+                LocalDate by = LocalDate.parse(splitInputs[1]);
+                Deadline newDeadline = new Deadline(description, by);
+                System.out.println("Bobby heard: " + newDeadline);


Maybe you can take all the System.out.println line into a new method in Ui class?

khoahre123 · 2022-02-03T12:53:35Z

src/main/java/bobby/BobbyException.java

+
+public class BobbyException extends Exception {
+    public BobbyException(String errorMessage) {
+        super(errorMessage);


I think you can turn this into a more customize file, instead of simply extends the Exception class

khoahre123 · 2022-02-03T12:54:10Z

src/main/java/bobby/Deadline.java

+
+    @Override
+    public String toString() {
+        return "[D]" + super.toString() + " (by: " + by.format(DateTimeFormatter.ofPattern("MMM d yyyy")) + ")";


Should the break line be 8 spaces indent compared to the parent line?

khoahre123 · 2022-02-03T12:55:37Z

src/main/java/bobby/Parser.java

+                } catch (BobbyException e) {
+                    System.out.println(e);
+                } catch (DateTimeParseException e) {
+                    System.out.println("Invalid date format. Please use YYYY-MM-DD.");


I noticed the same issue in several other places too

…ementation

…() method in Bobby

…ye" command Change GUI display pictures Ensure text is displayed fully for long tasklists

To ensure assumptions and ease of debugging for future extensions Let's insert assert statements in various points to ensure assumptions hold and methods function as expected

Branch a assertions

…odeQuality # Conflicts: # src/main/java/bobby/Parser.java

This reverts commit 5b234ed.

Parse() method in Parser class do not have same level of abstraction and have common behaviors across several switch cases. Extracting out common behaviors into private methods in the class improves the code quality of the method as it now has single level of abstraction and do not have common behavior across cases. Let's extract out the splitting process into various private methods to split the input

style code

Branch a code quality

Undo command will help users correct their incorrect inputs easily. Let's keep track of the state of Bobby after each change made and implement the Undo command to reverse the most recent change.

damithc and others added 28 commits July 29, 2021 20:30

Add Gradle support

d839859

changed name of chatbot, completed level 1

45e1919

completed level-2

10e1c56

fixed level-2, included print when item is added to list

60bef02

Implemented task.java, completed Level-3

607dc75

added Deadline, Event, Todo classes. Updated toString method in Task …

06e90b1

…and cleaned up print statements in Bobby.

completed Level-4

ea68bac

added test cases, fixed exception occurring due to scanner object hav…

1ad8f96

…ing no next line

Created methods for adding Task to list and methods now throw BobbyEx…

4755e73

…ceptions and are handled in the main method

implemented delete method, completed level-6

99c17e4

add use of enum, create new bobby.txt file at start of program

f53833a

add writeToFile

191572a

add writeToFile() methods to various tasks, implement write and loadi…

5f403a3

…ng for bobby

add date with LocalDate type for deadlines

4e3fd88

Merge branch 'branch-Level-8'

888d0d9

# Conflicts: # src/main/java/Deadline.java

extract out Parser, Ui, Tasklist, and Storage classes to apply OOP pr…

993e805

…inciples

create bobby package

4a64201

Merge remote-tracking branch 'origin/add-gradle-support'

189338e

add junit tests for todo, dealine and invalid input

5c62f9e

change build name to bobby

b0c01d9

clean up some code, insert javadocs for bobby.java

2ad4931

write javadocs for Parser, Bobby, Storage and TaskList classes

b8e7c6c

tweak code to adhere to CodingStandards, add and run checkstyle

e49f9a3

add Find function

7734195

Merge branch 'branch-A-CodingStandard'

244d256

# Conflicts: # src/main/java/bobby/Bobby.java

resolve merge conflicts

6db3d1b

Merge branch 'branch-level-9'

fbde2d8

insert javadocs for Find

d1a8f67

khoahre123 reviewed Feb 3, 2022

View reviewed changes

YiFei2 marked this pull request as draft February 3, 2022 17:50

YiFei2 and others added 28 commits February 7, 2022 00:58

add MainWindow, Main, Launcher, DialogBox classes for javafx GUI impl…

98ae8a7

…ementation

Change Parse in Parser to return String type, implemented getResponse…

868e72b

…() method in Bobby

Refine GUI to display welcome message and allow user to exit using "b…

c01b714

…ye" command Change GUI display pictures Ensure text is displayed fully for long tasklists

fix minor bugs with dialogbox and building jar file

4f0af17

enable assertions

4d5c2e3

Current code do not have assertions

b03df4c

To ensure assumptions and ease of debugging for future extensions Let's insert assert statements in various points to ensure assumptions hold and methods function as expected

Merge pull request #1 from YiFei2/branch-A-Assertions

4a881af

Branch a assertions

improve code quality

31cb02b

Merge branch 'master' of https://github.com/YiFei2/ip into branch-A-C…

918eaa5

…odeQuality # Conflicts: # src/main/java/bobby/Parser.java

resolve merge conflicts

5b234ed

Revert "resolve merge conflicts"

a1eac3d

This reverts commit 5b234ed.

extract creation of file in loadFile() method to resolve arrowhead

559bd57

style code

remove unused method

defd497

Merge pull request #2 from YiFei2/branch-A-CodeQuality

c06ac94

Branch a code quality

Clean up code, implement State class and stateStack

8c109f1

implement stateStack

f046145

implement undo

04f7f5d

Implement Undo command

735a871

Undo command will help users correct their incorrect inputs easily. Let's keep track of the state of Bobby after each change made and implement the Undo command to reverse the most recent change.

Fix up javadocs and coding standard issues

878f6dc

Edit Readme.md and add Ui.png

465398b

Set theme jekyll-theme-slate

8589ac3

Update README.md

804bc4d

Update README.md

1fc6606

Update README.md

39fecc6

Update README.md

f12ca3b

rename Ui.png to Ui

6b8379d

Merge branch 'master' of https://github.com/YiFei2/ip

ceba7eb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fong Yi Fei] iP #282

[Fong Yi Fei] iP #282

YiFei2 commented Jan 28, 2022 •

edited

Loading

khoahre123 left a comment

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

khoahre123 Feb 3, 2022

[Fong Yi Fei] iP #282

Are you sure you want to change the base?

[Fong Yi Fei] iP #282

Conversation

YiFei2 commented Jan 28, 2022 • edited Loading

It's Bobby.

Features

What can Bobby remember?

Here is how Bobby would encourage you in taskDone

An example of what you could do with Bobby.

khoahre123 left a comment

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

khoahre123 Feb 3, 2022

Choose a reason for hiding this comment

YiFei2 commented Jan 28, 2022 •

edited

Loading

Here is how Bobby would encourage you in `taskDone`