Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fong Yi Fei] iP #282

Draft
wants to merge 56 commits into
base: master
Choose a base branch
from
Draft

[Fong Yi Fei] iP #282

wants to merge 56 commits into from

Commits on Jul 29, 2021

  1. Add Gradle support

    damithc authored and damithc committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    d839859 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. changed name of chatbot, completed level 1

    @YiFei2
    YiFei2 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    45e1919 View commit details
    Browse the repository at this point in the history

  2. completed level-2

    @YiFei2
    YiFei2 committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    10e1c56 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. fixed level-2, included print when item is added to list

    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    60bef02 View commit details
    Browse the repository at this point in the history

  2. Implemented task.java, completed Level-3

    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    607dc75 View commit details
    Browse the repository at this point in the history

  3. added Deadline, Event, Todo classes. Updated toString method in Task … 

    …and cleaned up print statements in Bobby.
    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    06e90b1 View commit details
    Browse the repository at this point in the history

  4. completed Level-4

    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ea68bac View commit details
    Browse the repository at this point in the history

  5. added test cases, fixed exception occurring due to scanner object hav… 

    …ing no next line
    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    1ad8f96 View commit details
    Browse the repository at this point in the history

  6. Created methods for adding Task to list and methods now throw BobbyEx… 

    …ceptions and are handled in the main method
    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    4755e73 View commit details
    Browse the repository at this point in the history

  7. implemented delete method, completed level-6

    @YiFei2
    YiFei2 committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    99c17e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. add use of enum, create new bobby.txt file at start of program

    @YiFei2
    YiFei2 committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    f53833a View commit details
    Browse the repository at this point in the history

  2. add writeToFile

    @YiFei2
    YiFei2 committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    191572a View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. add writeToFile() methods to various tasks, implement write and loadi… 

    …ng for bobby
    @YiFei2
    YiFei2 committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    5f403a3 View commit details
    Browse the repository at this point in the history

  2. add date with LocalDate type for deadlines

    @YiFei2
    YiFei2 committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    4e3fd88 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-Level-8' 

    # Conflicts:
#	src/main/java/Deadline.java
    @YiFei2
    YiFei2 committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    888d0d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2022

  1. extract out Parser, Ui, Tasklist, and Storage classes to apply OOP pr… 

    …inciples
    @YiFei2
    YiFei2 committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    993e805 View commit details
    Browse the repository at this point in the history

  2. create bobby package

    @YiFei2
    YiFei2 committed Jan 30, 2022
    Configuration menu
    Copy the full SHA
    4a64201 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Merge remote-tracking branch 'origin/add-gradle-support'

    @YiFei2
    YiFei2 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    189338e View commit details
    Browse the repository at this point in the history

  2. add junit tests for todo, dealine and invalid input

    @YiFei2
    YiFei2 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    5c62f9e View commit details
    Browse the repository at this point in the history

  3. change build name to bobby

    @YiFei2
    YiFei2 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    b0c01d9 View commit details
    Browse the repository at this point in the history

  4. clean up some code, insert javadocs for bobby.java

    @YiFei2
    YiFei2 committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    2ad4931 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. write javadocs for Parser, Bobby, Storage and TaskList classes

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    b8e7c6c View commit details
    Browse the repository at this point in the history

  2. tweak code to adhere to CodingStandards, add and run checkstyle

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    e49f9a3 View commit details
    Browse the repository at this point in the history

  3. add Find function

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    7734195 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'branch-A-CodingStandard' 

    # Conflicts:
#	src/main/java/bobby/Bobby.java
    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    244d256 View commit details
    Browse the repository at this point in the history

  5. resolve merge conflicts

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    6db3d1b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'branch-level-9'

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    fbde2d8 View commit details
    Browse the repository at this point in the history

  7. insert javadocs for Find

    @YiFei2
    YiFei2 committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    d1a8f67 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. add MainWindow, Main, Launcher, DialogBox classes for javafx GUI impl… 

    …ementation
    @YiFei2
    YiFei2 committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    98ae8a7 View commit details
    Browse the repository at this point in the history

  2. Change Parse in Parser to return String type, implemented getResponse… 

    …() method in Bobby
    @YiFei2
    YiFei2 committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    868e72b View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Refine GUI to display welcome message and allow user to exit using "b… 

    …ye" command

Change GUI display pictures
Ensure text is displayed fully for long tasklists
    @YiFei2
    YiFei2 committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    c01b714 View commit details
    Browse the repository at this point in the history

  2. fix minor bugs with dialogbox and building jar file

    @YiFei2
    YiFei2 committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4f0af17 View commit details
    Browse the repository at this point in the history

  3. enable assertions

    @YiFei2
    YiFei2 committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4d5c2e3 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Current code do not have assertions 

    To ensure assumptions and ease of debugging for future extensions

Let's insert assert statements in various points to ensure
assumptions hold and methods function as expected
    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    b03df4c View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from YiFei2/branch-A-Assertions 

    Branch a assertions
    @YiFei2
    YiFei2 authored Feb 10, 2022
    Configuration menu
    Copy the full SHA
    4a881af View commit details
    Browse the repository at this point in the history

  3. improve code quality

    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    31cb02b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/YiFei2/ip into branch-A-C… 

    …odeQuality

# Conflicts:
#	src/main/java/bobby/Parser.java
    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    918eaa5 View commit details
    Browse the repository at this point in the history

  5. resolve merge conflicts

    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    5b234ed View commit details
    Browse the repository at this point in the history

  6. Revert "resolve merge conflicts" 

    This reverts commit 5b234ed.
    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    a1eac3d View commit details
    Browse the repository at this point in the history

  7. Parser class: extract out methods to do splitting 

    Parse() method in Parser class do not have same level of abstraction
and have common behaviors across several switch cases.

Extracting out common behaviors into private methods in the class
improves the code quality of the method as it now has single level
of abstraction and do not have common behavior across cases.

Let's extract out the splitting process into various private methods
to split the input
    @YiFei2
    YiFei2 committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    1a1bc29 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. extract creation of file in loadFile() method to resolve arrowhead 

    style code
    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    559bd57 View commit details
    Browse the repository at this point in the history

  2. remove unused method

    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    defd497 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from YiFei2/branch-A-CodeQuality 

    Branch a code quality
    @YiFei2
    YiFei2 authored Feb 11, 2022
    Configuration menu
    Copy the full SHA
    c06ac94 View commit details
    Browse the repository at this point in the history

  4. Clean up code, implement State class and stateStack

    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8c109f1 View commit details
    Browse the repository at this point in the history

  5. implement stateStack

    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    f046145 View commit details
    Browse the repository at this point in the history

  6. implement undo

    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    04f7f5d View commit details
    Browse the repository at this point in the history

  7. Implement Undo command 

    Undo command will help users correct their incorrect inputs easily.

Let's keep track of the state of Bobby after each change made and
implement the Undo command to reverse the most recent change.
    @YiFei2
    YiFei2 committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    735a871 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Fix up javadocs and coding standard issues

    @YiFei2
    YiFei2 committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    878f6dc View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2022

  1. Edit Readme.md and add Ui.png

    @YiFei2
    YiFei2 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    465398b View commit details
    Browse the repository at this point in the history

  2. Set theme jekyll-theme-slate

    @YiFei2
    YiFei2 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    8589ac3 View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @YiFei2
    YiFei2 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    804bc4d View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @YiFei2
    YiFei2 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    1fc6606 View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @YiFei2
    YiFei2 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    39fecc6 View commit details
    Browse the repository at this point in the history

  6. Update README.md

    @YiFei2
    YiFei2 authored Feb 20, 2022
    Configuration menu
    Copy the full SHA
    f12ca3b View commit details
    Browse the repository at this point in the history

  7. rename Ui.png to Ui

    @YiFei2
    YiFei2 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    6b8379d View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of https://github.com/YiFei2/ip

    @YiFei2
    YiFei2 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    ceba7eb View commit details
    Browse the repository at this point in the history