Fix mouse tracking in Electron.

[hwf1324]

Link to issue number:

Fixed #17108, #17190

Summary of the issue:

A fix was introduced in recent Electron applications that caused the mouse tracking to stay on a pane control that covered the entire window.
Unfortunately, since we can't fix it on Electron's part, we have to fix it in NVDA.

Description of user facing changes

Mouse tracking works in Electron applications.

Description of development approach

Use objectFromPointRedirect to redirect the object under the mouse to the correct object.

Testing strategy:

Manual testing, e.g. mouse tracking works correctly in VS COde 1.92 and higher.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[hwf1324]

For code organization, is it necessary to create a separate Electron module?

Are there any optimization suggestions for determining object hits?

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/9vxabx51n557ro4m/artifacts/output/nvda_snapshot_pr17225-34182,54863ba7.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.4,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 16.4,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.4,
  TEST_START 0.0,
  TEST_END 18.7,
  FINISH_END 0.1

See test results for failed build of commit 54863ba794

[seanbudd]

this seems fragile and may include other documents unexpectedly

[hwf1324]

Do you have any suggestions?
Adding more constraints like before? Does this add more overhead?

I haven't encountered any problems with it in practice, at least so far.

[SaschaCowley]

Ideally this would have an ID we could query to positively identify it.
Or even better, would just get fixed on the Electron side

[hwf1324]

#17108 (comment)

Unfortunately, I'm afraid that won't work.
In the comment pointed to by the link above, I mentioned that there are differences in the mouse objects that prevent the use of 'Chrome_WidgetWin_1' as a judgment condition.

[cary-rowen]

BTW, this PR will also fix the issue of not being able to find the status bar in VS Code.

[cary-rowen]

Hi @SaschaCowley @seanbudd
Is action required from the author before the next review?

[seanbudd]

Is action required from the author before the next review?

We won't accept the current approach. We may come back later with suggested alternatives if we can think of any, but the current approach is too fragile and risky.