Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse tracking in Electron. #17225

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+27 −1
Open

Fix mouse tracking in Electron. #17225

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
243b7a9
Fix mouse tracking in Electron.
hwf1324 Sep 27, 2024
e7b5044
Apply suggestions from comments
hwf1324 Sep 27, 2024
6c4c9af
Applying the recommendations of the code review
hwf1324 Sep 30, 2024
6ad8b83
Merge branch 'master' into fixElectronMouseTracking
hwf1324 Sep 30, 2024
23368ac
Update source/NVDAObjects/IAccessible/chromium.py
hwf1324 Sep 30, 2024
01d87bb
Update user_docs/en/changes.md
hwf1324 Sep 30, 2024
fbbd3d3
Merge remote-tracking branch 'origin/master' into fixElectronMouseTra…
hwf1324 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/NVDAObjects/IAccessible/chromium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class Editor(ia2Web.Editor):
class RedirectDocument(ia2Web.Ia2Web):
"""The NVDAObject for the redirect document object in Electron."""

def objectFromPointRedirect(self, x: int, y: int):
def objectFromPointRedirect(self, x: int, y: int) -> IAccessible:
hwf1324 marked this conversation as resolved.
Show resolved Hide resolved
docObj: Document = self.previous.lastChild
redirect = docObj.IAccessibleObject.accHitTest(x, y)

Expand Down
3 changes: 2 additions & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ In order to use this feature, the application volume adjuster needs to be enable
* NVDA is able to read the popup submenu items on Thunderbird search results page. (#4708, @thgcode)
* The COM Registration Fixing Tool no longer reports success on failure. (#12355, @XLTechie)
* When using the Microsoft Pinyin Input Method for Chinese and enabling the Pinyin compatibility option to use the previous version, typing in LibreOffice Writer (and potentially other applications) while an IME popup is showing no longer triggers an error. (#17198, @michaelweghorn)
* Fix mouse tracking in Electron. (#17108, #17190, @hwf1324)
* In LibreOffice, the current checkbox state (checked/unchecked) is now also reported in braille, not just speech. (#17218, @michaelweghorn)
* Fix mouse tracking in Electron. E.g. VS Code. (#17108, #17190, @hwf1324)
hwf1324 marked this conversation as resolved.
Show resolved Hide resolved

### Changes for Developers

Expand Down