-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed text for allow NVDA to control the volume of other apps #17317
base: master
Are you sure you want to change the base?
Conversation
@XLTechie, would you mind reviewing the wording changed in this PR? Maybe what is reported when using the toggle command is a bit long, but I have not found something shorter. Also cc @wmhn1872265132 (author of #17303) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CyrilleB79 Here are some English wording suggestions. Note that I have not been following all of the intricacies of this feature. But these more closely represent in English, what I think was intended.
I have given two alternatives for each message (action word first, action word last), and have also given two slightly different wordings (one set in the enabled suggestions, and one set in the disabled suggestions), that you can of course adjust to your preference.
HTH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User guide and UI text looks fine.
Co-authored-by: Luke Davis <[email protected]>
Co-authored-by: Luke Davis <[email protected]>
Many thanks @XLTechie for your review. I have committed your suggestions and/or reworded taking into account of them. Should be OK now. |
Co-authored-by: Luke Davis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Link to issue number:
Fixes #17303
Summary of the issue:
Associated to the audio new option "Allow NVDA to control the volume of other applications" (ex Volume adjuster), there is a command (script) with no default bound gesture to toggle the value of this parameter. There are two issues with this script:
Description of user facing changes
Description of development approach
See code.
Testing strategy:
Manual test.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary