Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed text for allow NVDA to control the volume of other apps #17317

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixed text for allow NVDA to control the volume of other apps #17317

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8621816
Fixed allow NVDA to control the volume of other apps
CyrilleB79 Oct 22, 2024
28c6cc7
Update options in the User Guide
CyrilleB79 Oct 22, 2024
643e9bb
Remove a file created by error
CyrilleB79 Oct 22, 2024
fb08988
Update source/audio/appsVolume.py
CyrilleB79 Oct 23, 2024
6ee6799
Update source/globalCommands.py
CyrilleB79 Oct 23, 2024
4c36b63
Reword translators comment
CyrilleB79 Oct 23, 2024
f4178f0
Update source/audio/appsVolume.py
CyrilleB79 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion source/audio/appsVolume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,15 @@ def _toggleAppsVolumeState():
state = _APPS_VOLUME_STATES_ORDER[index]
config.conf["audio"]["applicationsVolumeMode"] = state.name
_updateAppsVolumeImpl(volume / 100.0, muted, state)
ui.message(state.displayString)
if state == AppsVolumeAdjusterFlag.ENABLED:
# Translators: Reported as a result of the command to toggle whether control of other applications' volume
# is enabled.
msg = _("Enabled control of other applications' volume")
else:
# Translators: Reported as a result of the command to toggle whether control of other applications' volume
# is enabled.
msg = _("Enabled control of other applications' volume")
CyrilleB79 marked this conversation as resolved.
Show resolved Hide resolved
ui.message(msg)


def _toggleAppsVolumeMute():
Expand Down
3 changes: 1 addition & 2 deletions source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4775,10 +4775,9 @@ def script_decreaseApplicationsVolume(self, gesture: "inputCore.InputGesture") -
@script(
description=_(
# Translators: Describes a command.
"Toggles other applications volume adjuster status",
"Toggle whether control of other applications' volume is enabled.",
),
category=SCRCAT_AUDIO,
gesture=None,
)
def script_toggleApplicationsVolumeAdjuster(self, gesture: "inputCore.InputGesture") -> None:
appsVolume._toggleAppsVolumeState()
Expand Down
2 changes: 1 addition & 1 deletion user_docs/en/userGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2469,7 +2469,7 @@ This option is not available if you have started NVDA with [WASAPI disabled for

| . {.hideHeaderRow} |.|
|---|---|
|Options |No, Yes|
|Options |Default (No), No, Yes|
|Default |No|

This combo box determines whether NVDA commands can be used to adjust the volume of other applications running on the system.
Expand Down