Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font docs; bad-translation-food for RU/PL fonts #21

Closed
wants to merge 2 commits into from

Conversation

jdlcdl
Copy link

@jdlcdl jdlcdl commented Sep 10, 2023

I'm not necessarily intending for this to be merged.

It is rather to be used as supplemental information for a pr to odudex/MaixPy where font.c files were touched, so you know how those values were created.

README.md is updated because I find it easier to vi all font.c files at once, move to the unicode array definition, delete its r-value, read in the appropriate .kff file, write it, and onto the next font.c file. Also, I've altered a .kff filename to include yahboom... but maybe "small.kff", "medium.kff" and "large.kff" (or "three_cm.kff", "six_cm.kff" and "nine_cm.kff") could work too.

ru-RU.json and pl-PL.json are 100% google-translate filled. Additionally, the translated string for "ABC" has been given more food just after the space character (which would look funny in the keyboard, so remove those extra chars and re-bake if building to see RU and PL). Still they're at least initialized and up to date with develop_rc code base.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3d6252c) 92.14% compared to head (b81b15d) 92.14%.
Report is 5 commits behind head on develop_rc.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop_rc      #21   +/-   ##
===========================================
  Coverage       92.14%   92.14%           
===========================================
  Files              42       42           
  Lines            5273     5273           
===========================================
  Hits             4859     4859           
  Misses            414      414           
Files Changed Coverage Δ
src/krux/translations.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex
Copy link
Owner

odudex commented Sep 18, 2023

Changes were picked and merged on branch I'll be working from now on: develop_irq_based

@odudex odudex closed this Sep 18, 2023
@jdlcdl jdlcdl deleted the fonts_RU_PL branch July 21, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants