Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic #1083] Add tests for nontrivial run length encode API #393

Merged
merged 3 commits into from
Aug 17, 2023
Merged

[SYCLomatic #1083] Add tests for nontrivial run length encode API #393

merged 3 commits into from
Aug 17, 2023

Conversation

mmichel11
Copy link
Contributor

@mmichel11 mmichel11 commented Jul 11, 2023 •
edited
Loading

This PR adds tests to the API provided in oneapi-src/SYCLomatic#1083. We test the API with various run length encoding inputs (standard case, runs at the beginning and end of buffer, one large run, no runs at all, and different types).

Note that for the implementation to compile oneapi-src/oneDPL#1019 must be first merged into oneDPL.

@mmichel11 mmichel11 mentioned this pull request Jul 12, 2023
Merged
@mmichel11 mmichel11 marked this pull request as ready for review July 14, 2023 17:59
@mmichel11 mmichel11 requested a review from a team as a code owner July 14, 2023 17:59
danhoeflinger
danhoeflinger reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor issue in comment.

help_function/src/onedpl_test_nontrivial_run_length_encode.cpp Outdated
@@ -0,0 +1,227 @@
// ====------ onedpl_test_run_length_encode.cpp---------- -*- C++ -* ----===////
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix file name in comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mmichel11
Fix test filename
077eb3c 
Signed-off-by: Matthew Michel <[email protected]>
danhoeflinger
danhoeflinger approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomflinda
tomflinda approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShengchenJ ShengchenJ merged commit 39bc1ba into oneapi-src:SYCLomatic Aug 17, 2023
12 checks passed
@ShengchenJ ShengchenJ mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhoeflinger danhoeflinger danhoeflinger approved these changes

@ShengchenJ ShengchenJ ShengchenJ approved these changes

@tomflinda tomflinda tomflinda approved these changes

@zhimingwang36 zhimingwang36 Awaiting requested review from zhimingwang36 zhimingwang36 is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmichel11 @tomflinda @ShengchenJ @danhoeflinger