Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic] Add run length encode nontrivial runs API #1083

Conversation

mmichel11
Copy link
Contributor

@mmichel11 mmichel11 commented Jul 11, 2023

This PR implements the run length encoding nontrivial runs API. In order for the added source code in this PR to compile, oneapi-src/oneDPL#1019 must be first merged into oneDPL. The corresponding test PR for this implementation is provided in oneapi-src/SYCLomatic-test#393

Nontrivial runs are a subsequence of length two or greater in a buffer that are equivalent. This API marks the start of each nontrivial run, length of each nontrivial run, and the number of nontrivial runs.

@mmichel11 mmichel11 marked this pull request as ready for review July 14, 2023 17:57
@mmichel11 mmichel11 requested a review from a team as a code owner July 14, 2023 17:57
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is improved, but I think there may be a bug and some unnecessary code.

clang/runtime/dpct-rt/include/dpl_extras/algorithm.h Outdated Show resolved Hide resolved
clang/runtime/dpct-rt/include/dpl_extras/algorithm.h Outdated Show resolved Hide resolved
clang/runtime/dpct-rt/include/dpl_extras/algorithm.h Outdated Show resolved Hide resolved
clang/runtime/dpct-rt/include/dpl_extras/algorithm.h Outdated Show resolved Hide resolved
Signed-off-by: Matthew Michel <[email protected]>
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Copy link
Contributor

@yihanwg yihanwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit 4d5fb54 into oneapi-src:SYCLomatic Jul 24, 2023
daiyaan-ahmed6 pushed a commit to daiyaan-ahmed6/SYCLomatic that referenced this pull request Aug 1, 2023
daiyaan-ahmed6 pushed a commit to daiyaan-ahmed6/SYCLomatic that referenced this pull request Aug 4, 2023
ShengchenJ pushed a commit to ShengchenJ/SYCLomatic that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants