-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutability changes to Cadence documentation #172
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
access(Map) fun getRef(): auth(Map) &SubResource { | ||
return &self.childResource as auth(Map) &SubResource | ||
} | ||
access(Map) let childResource: @SubResource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has documentation already been added/changed for entitlement mappings explaining how they work with resource-typed fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not specifically add about resource typed fields, since this section already describes how entitlement mappings pass down the entitlements in general. Also, the newly added Field and Index Access
(in reference.md) section describes how references and entitlements are received when accessing fields through a reference.
If we want to have a more granular/in-depth explanation on how entitlement mappings behave on each different use case (functions, references, and container-typed field) separately, then I guess that also makes sense and would be good to have it too. But probably unrelated to this change, so maybe we could do it in a separate PR?
Co-authored-by: Daniel Sainati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Maybe wait for @dsainati1's final approval before merging |
Closes onflow/cadence#2684
Update documentation with the changes introduced in mutability FLIPs: onflow/flips#89, onflow/flips#86, and onflow/flips#94