Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mutability changes to Cadence documentation #172
Add mutability changes to Cadence documentation #172
Changes from all commits
f59cad4
c68da4d
0f95aa4
c9dc556
8d8fd5c
6dbc4fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has documentation already been added/changed for entitlement mappings explaining how they work with resource-typed fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not specifically add about resource typed fields, since this section already describes how entitlement mappings pass down the entitlements in general. Also, the newly added
Field and Index Access
(in reference.md) section describes how references and entitlements are received when accessing fields through a reference.If we want to have a more granular/in-depth explanation on how entitlement mappings behave on each different use case (functions, references, and container-typed field) separately, then I guess that also makes sense and would be good to have it too. But probably unrelated to this change, so maybe we could do it in a separate PR?