update script with latest zenoh api #149
Conversation
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
6 times, most recently
from
9fddeac
to
dee69c4
Compare
|
I saw that migrating to zenoh 1.0.0 was on your todo list and I needed it so I migrated it. I also was able to run it on humble with rmf_ros2 2.7.1 tag. |
There was a problem hiding this comment.
Thanks for the huge help with the migration! Yes I was definitely planning to get to 1.0.0 soon, but was hesitant with it still being in beta, and free_fleet's lack of static and integration tests (it's WIP though!)
I've just done a first pass and left a few comments, I'll need to run some tests manually too. The merge conflict is most definitely from #146, where some minor tests and testing infra have been added
edit: just curious, have you been testing with hardware? Or with the simulation examples so far?
free_fleet_adapter/setup.py
Outdated
| ( | ||
| os.path.join("share", package_name, "fleet_configs"), | ||
| glob("fleet_configs/*.yaml"), | ||
| ), |
There was a problem hiding this comment.
I'm guessing this might be left over from your own project?
| @@ -220,16 +222,17 @@ def navigate(self, destination, execution): | |||
| behavior_tree="" | |||
| ) | |||
|
|
|||
| print("about to get the action") | |||
There was a problem hiding this comment.
We should probably remove testing printouts, unless you find it necessary, we could convert it into a self.node.get_logger().debug(..., with more information about the goal message
| # timeout=0.5 | ||
| ) | ||
| for reply in replies.receiver: | ||
| print("finished to get the action") |
There was a problem hiding this comment.
This looks to be a testing printout as well
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
dee69c4
to
0c8311d
Compare
Signed-off-by: thomasung <[email protected]>
Signed-off-by: thomasung <[email protected]>
Signed-off-by: thomasung <[email protected]> clean dangling code
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
0c8311d
to
9625a6f
Compare
Signed-off-by: thomasung <[email protected]>
tomkimsour
force-pushed
the
easy-full-control-zenoh-1.0.0.b4
branch
from
6b3590d
to
eb48b1f
Compare
New feature implementation
Implemented feature
Migrate zenoh to zenoh 1.0.0.b4