Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a new release #1010

Closed
saschagrunert opened this issue May 15, 2019 · 15 comments · Fixed by #1037
Closed

Tag a new release #1010

saschagrunert opened this issue May 15, 2019 · 15 comments · Fixed by #1037

Comments

@saschagrunert
Copy link
Contributor

Hi there,

Do you think it would be possible to tag a new release according to semver? Some go module based dependencies have to rewrite their go.mod to get the latest features in. 😇 Thanks in advance! :)

@cyphar
Copy link
Member

cyphar commented May 15, 2019

The main thing I'd like to see be ready before a new runtime-spec release is the resolution of #1008 -- which will allow runc to have a 1.0 release. (Tagging releases, especially spec releases, in OCI is a bit of a hassle.)

@h-vetinari
Copy link
Contributor

It seems the resolution of #1008 is held up mainly by waiting for someone to review the PR. ;-)

@onlyjob
Copy link

onlyjob commented Sep 11, 2019

Formal release is long overdue... Because of that some projects (namely runtime-tools) already deviated from good practice of vendoring by tag...

@vbatts
Copy link
Member

vbatts commented Dec 17, 2019

to echo @h-vetinari, we are waiting on #1008 for a next release of the spec, and of runc-1.0.0 😬

@h-vetinari
Copy link
Contributor

#1008 has been merged a week ago. Is all that's necessary a PR with a tag? I'm guessing this is better left to the maintainers, but according to several comments all over the place, runtime-spec 1.0.2 should be ready?

@vbatts vbatts mentioned this issue Jan 9, 2020
@vbatts
Copy link
Member

vbatts commented Jan 9, 2020

vote for release is posted

@h-vetinari
Copy link
Contributor

h-vetinari commented Feb 3, 2020

#1026 failed due to not meeting the 2/3 quorum of maintainers; since then, two inactive maintainers have stepped down, meaning the quorum could now be reached with the LGTMs from the last vote alone. Since a nit** was brought up by @kad on the vote thread anyway, I thought it'd be good to double-check the state of open PRs - not to further delay the release, but to pick up already finished changes, since runtime-spec releases are few and far between. In descending order of approval:

For completeness, the remaining open PRs are probably not ready / necessary for a last-minute merge:


**

@kad: There is one questionable statement introduced by PRs #988 and #932 about Intel RDT closID state, which in theory should require small clarification:
One case that is not covered in the description is

"If closID is set and neither l3CacheSchema nor memBwSchema is set".
In this case, I think, runtime should check if closID exists in the resctrl and assign container to it.
If this closID does not exist in resctl - error.

@vbatts
Copy link
Member

vbatts commented Feb 4, 2020

Good list. Would want to try your hand at carrying over #937 ?

@h-vetinari
Copy link
Contributor

Updated the list.

@h-vetinari
Copy link
Contributor

All the open PRs that could still be considered for the next release are exceedingly trivial and could be finished if two devs took half an hour each.

In any case, now that two months have passed since the first quorum, it's really time to get this release done, IMHO.

@h-vetinari
Copy link
Contributor

Only two PRs left that could realistically still squeeze into 1.0.2. If anyone except @tianon (who already LGTM'd) could look at #1034 #1035, there'd be nothing left but to actually release it. :)
@crosbymichael @mrunalp @vbatts @dqminh @hqhq

@h-vetinari
Copy link
Contributor

All done; thanks @vbatts! 🎉
Any ETA on sending out the vote?

@h-vetinari
Copy link
Contributor

Another week, another ping (I'm sorry for apparently talking to myself here 😅)

@h-vetinari
Copy link
Contributor

I don't want to presume that a release-PR from a non-maintainer would be welcome, but in case it is, I have a branch ready that updates #1026 with the changes that have happened since then.

@vbatts vbatts mentioned this issue Mar 24, 2020
@vbatts
Copy link
Member

vbatts commented Mar 24, 2020

vote posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants