-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag a new release #1010
Comments
The main thing I'd like to see be ready before a new runtime-spec release is the resolution of #1008 -- which will allow runc to have a 1.0 release. (Tagging releases, especially spec releases, in OCI is a bit of a hassle.) |
It seems the resolution of #1008 is held up mainly by waiting for someone to review the PR. ;-) |
Formal release is long overdue... Because of that some projects (namely runtime-tools) already deviated from good practice of vendoring by tag... |
to echo @h-vetinari, we are waiting on #1008 for a next release of the spec, and of runc-1.0.0 😬 |
#1008 has been merged a week ago. Is all that's necessary a PR with a tag? I'm guessing this is better left to the maintainers, but according to several comments all over the place, |
vote for release is posted |
#1026 failed due to not meeting the 2/3 quorum of maintainers; since then, two inactive maintainers have stepped down, meaning the quorum could now be reached with the LGTMs from the last vote alone. Since a nit** was brought up by @kad on the vote thread anyway, I thought it'd be good to double-check the state of open PRs - not to further delay the release, but to pick up already finished changes, since runtime-spec releases are few and far between. In descending order of approval:
For completeness, the remaining open PRs are probably not ready / necessary for a last-minute merge:
**
|
Good list. Would want to try your hand at carrying over #937 ? |
Updated the list. |
All the open PRs that could still be considered for the next release are exceedingly trivial and could be finished if two devs took half an hour each. In any case, now that two months have passed since the first quorum, it's really time to get this release done, IMHO. |
All done; thanks @vbatts! 🎉 |
Another week, another ping (I'm sorry for apparently talking to myself here 😅) |
I don't want to presume that a release-PR from a non-maintainer would be welcome, but in case it is, I have a branch ready that updates #1026 with the changes that have happened since then. |
vote posted! |
Hi there,
Do you think it would be possible to tag a new release according to semver? Some go module based dependencies have to rewrite their go.mod to get the latest features in. 😇 Thanks in advance! :)
The text was updated successfully, but these errors were encountered: