config-windows: Added support for network namespace #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Bansal <[email protected]>
|
I would opt for |
|
@crosbymichael There's a lot of inconsistency throughout where namespace is used. However, I think what Sandeep has done here is consistent with the Windows part of the spec. Hence LGTM |
|
Ping @crosbymichael Could you please approve this PR? |
|
cc @jhowardmsft |
|
Don't you have to update the go structs as well? |
|
@crosbymichael i have created a new PR with the changes to go structs as well. #989 Could you please approve this PR? i will ask Sandeep to abandon this PR. |
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the next version of windows we have added support for network namespaces. With this support there is no need to manipulate endpoints individually. This brings windows in parity with other implementations(for networking).
Signed-off-by: Sandeep Bansal [email protected]