fix(envoy-filter): properly removes headers #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs: ``` envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930 script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument opendatahub-io#1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string` ``` This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as `Managed()`. This ensures that updating the existing filters will happen on operator upgrade or next reconcile.
zdtsw
approved these changes
Jul 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 022f456
into
opendatahub-io:incubation
8 checks passed
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
Current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs: ``` envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930 script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument #1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string` ``` This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as `Managed()`. This ensures that updating the existing filters will happen on operator upgrade or next reconcile. (cherry picked from commit 022f456)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
Current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs: ``` envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930 script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument #1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string` ``` This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as `Managed()`. This ensures that updating the existing filters will happen on operator upgrade or next reconcile. (cherry picked from commit 022f456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation incorrectly calls removal of a header which is manifested in ingress gateway proxy logs when trying to access inference service:
This fixes the Lua syntax and marks Service Mesh Features related to KServe setup as
Managed(). This ensures that updating the existing filters will happen on operator upgrade or next reconcile.How Has This Been Tested?
incubationoperatoroc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml. Notice wrong syntax.removein Lua snippetoc get envoyfilter/envoy-oauth-temp-fix-after -n istio-system -o yaml. Notice correct/patched syntax:removein Lua snippetScreenshot or short clip
Merge criteria