Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(envoy-filter): properly removes headers #1108

Merged

Commits on Jul 10, 2024

  1. fix(envoy-filter): properly removes headers

    Current implementation incorrectly calls removal of a header which is
    manifested in ingress gateway proxy logs:
    
    ```
    envoy lua external/envoy/source/extensions/filters/http/lua/lua_filter.cc:930  script log: [string "function envoy_on_request(request_handle)..."]:10: bad argument opendatahub-io#1 to 'remove' (N5Envoy10Extensions11HttpFilters3Lua16HeaderMapWrapperE expected, got string`
    ```
    
    This fixes the Lua syntax and marks Service Mesh Features related to
    KServe setup as `Managed()`. This ensures that updating the existing
    filters will happen on operator upgrade or next reconcile.
    bartoszmajsak committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6648f30 View commit details
    Browse the repository at this point in the history