(fix): Change on trigger to pull_request_target in the "check-file-updates.yaml" action

[AjayJagan]

(fix): Change on trigger to pull_request_target in the "Check config and readme updates / Ensure generated files are included (pull_request)" action to fix "Resource not accessible by integration" error while running the action

Description

The "Check config and readme updates / Ensure generated files are included (pull_request)" action fails when trying to comment on the pr.
There are 2 cases which might cause this

1. The GITHUB_TOKEN does not have a pull-requests: write permission.
2. The workflow does not have Read and Write permission in the repo.

But the above 2 cases are satisfied for opendatahub-operator.

So the last possible case is to add change on: pull_request to on: pull_request _target(as per https://github.com/thollander/actions-comment-pull-request?tab=readme-ov-file#permissions). This does not ensure that it will work but this is going to be a trial.

Also, the same workflow was able to run in my repo: AjayJagan#517

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[AjayJagan]

Once this is merged, I can try to create a test pr by simulating a change in the apis.
If it works, we can keep this change, else I can revert this back and think of a different fix.

@zdtsw @bartoszmajsak ^

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (incubation@e8e266f). Learn more about missing BASE report.

Additional details and impacted files

@@              Coverage Diff              @@
##             incubation    #1296   +/-   ##
=============================================
  Coverage              ?   18.91%           
=============================================
  Files                 ?       30           
  Lines                 ?     2670           
  Branches              ?        0           
=============================================
  Hits                  ?      505           
  Misses                ?     2103           
  Partials              ?       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bartoszmajsak]

Once this is merged, I can try to create a test pr by simulating a change in the apis. If it works, we can keep this change, else I can revert this back and think of a different fix.

@zdtsw @bartoszmajsak ^

You could also try running the action on your fork instead of merging potentially not working solution in upstream repo.

[bartoszmajsak]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (incubation@e8e266f). Learn more about missing BASE report.

Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

I think this report is lying ;)

[AjayJagan]

tested on a fork : AjayJagan#527
and it works.
@bartoszmajsak ^

[AjayJagan]

@zdtsw @VaishnaviHire ^ JFyi :)

[zdtsw]

approved based on the test result

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ykaliuta]

@AjayJagan could you please keep first line of the commit message short enough and descriptive? First line is a bit special, it's a header of the patch. git log --oneline is a bit broken if the whole commit message formatted in one line.

[AjayJagan]

@AjayJagan could you please keep first line of the commit message short enough and descriptive? First line is a bit special, it's a header of the patch. git log --oneline is a bit broken if the whole commit message formatted in one line.

@ykaliuta , for sure :)