[Sync]: ODH for rhoai 2.15 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ODH: cb86031 Signed-off-by: Wen Zhou <[email protected]>
Add webhook.Init() function and hide webhook setup inside of the module. It will make it possible to replace Init with a NOP (no operation) with conditional compilation for no-webhook build. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit e40c770)
Make it possible to compile operator without webhook enabled (with
-tags nowebhook). Create a stub webhook.Init() function for that.
Add run-nowebhook target to run webhook locally. It requires
`make install` to be executed on the cluster beforehand.
Since it repeats `make run`, move the command to a variable.
Also use variable RUN_ARGS for operator arguments. It makes it
possible to override them from the command line.
In VSCode it is possible to debug it with the following example
launch.json configuration:
```
{
"name": "Debug Operator No Webhook",
"type": "go",
"request": "launch",
"mode": "debug",
"program": "main.go",
"buildFlags": [
"-tags", "nowebhook"
],
"env": {
"OPERATOR_NAMESPACE": "opendatahub-operator-system",
"DEFAULT_MANIFESTS_PATH": "./opt/manifests"
},
"args": [
"--log-mode=devel"
],
"cwd": "${workspaceFolder}",
}
```
Signed-off-by: Yauheni Kaliuta <[email protected]>
(cherry picked from commit e8e266f)
…lue (opendatahub-io#1298) - thses are only needed when it is downstream speicific cases Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit fa63b4d)
… config and readme updates / Ensure generated files are included (pull_request)" action to fix "Resource not accessible by integration" error while running the action (opendatahub-io#1296) Signed-off-by: AJAY JAGANATHAN <[email protected]> (cherry picked from commit f954f0b)
Signed-off-by: Wen Zhou <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test rhods-operator-e2e |
|
/lgtm |
openshift-merge-bot
bot
merged commit 2b9610c
into
red-hat-data-services:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to include ODH changes:
https://issues.redhat.com/browse/RHOAIENG-14209
How Has This Been Tested?
Screenshot or short clip
Merge criteria