Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impot sur le revenu #2370
base: master
Are you sure you want to change the base?
Impot sur le revenu #2370
Changes from 16 commits
15737d3
b3f4084
67c49aa
7e84101
4cb2483
e7e10ba
031aa9d
4d349e3
7584401
1f2dda4
97b9f04
8766346
fb21a20
0fa1c28
86e1a5d
7f5b52f
760c073
6610430
7c95bd2
5a03d68
b6cec55
f18870d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention : "gros" changement ici.
Il serait utile d'ajouter un test unitiaire et d'expliquer dans le changelog ce qui clôchaît.
Et bump de version mineur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonjour @benjello merci pour tes revues au fil de l'eau !
Oui c'est bien prévu d'indiquer que "un plus gros changement", l'idée ici est de permettre d'avoir un paramètre qui est au format proposé par la loi, à savoir un
coefficient de 1,25
et non25%
. Du coup j'ai dû toucher la formule.Pour les tests unitaires (je ne sais pas encore en faire, mais je pourrai avoir l'aide de l'équipe), j'ai l'intuition que les tests déjà présents n'ont pas à changer vu que c'est exactement le même résultat qui est attendu. Mais j'ai peut-être mal modifié la formule ?
La modif de formule que je souhaiter proposer ici avait pour objectif de :
This file was deleted.
This file was deleted.