Print a warning when the relations are invalid #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still this can be quite difficult for a user to notice... Im not sure how we could improve the situation |
signedav
requested changes
Oct 7, 2024
How is it solved on normal relation editor? On a quick test it seems that it's just ignored: |
This can happen if a relation is deleted after the widget was added Log a warning instead of throwing a python exception when trying to access referencedLayer()
domi4484
force-pushed
the
check-relations-validity
branch
from
a3c73a6
to
8b0a8b6
Compare
|
@signedav thanks for the review. Yes it QGIS it is just ignored. It would be good to add something visual like a warning logo or something like that in the layer properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if a relation is deleted after the widget was added to a layer configuration.
With this changes the issue persists but it logs a warning instead of throwing a python exception when trying to access referencedLayer()