Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sets default activity #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cjakeman
Copy link
Contributor

For Demo Model 1 and BNSF Starter Route.
Demo Model 1 has prompts during the only activity to help the newcomer use Open Rails.

For Demo Model 1 and BNSF Starter Route.
Demo Model 1 has prompts during the only activity to help the newcomer use Open Rails.
"headingto": "Berne",
"time": "12:00",
"season": "Winter",
"weather": "Snow"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this stuff below activity necessary? Can it override the activity or is it only going to cause confusion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ok with or without. Values do not get overwritten. Could be confusing when somehow one of the extra items get changed in the downloaded route (highly unlikable).

However the info webpage shows empty strings when left out from the routes.json:

Start options:

  • Installation profile: BNSF Starter Route
  • Activity: 1. What Goes Up...
  • Route: BNSF Scenic Sub
  • Locomotive:
  • Consist:
  • Starting at:
  • Heading to:
  • Time:
  • Season:
  • Weather:

I would suggest removing the extra fields from routes.json, it is redundant information anyway. And let me add an extra if in the code generating the info webpage. And on this webpage the lines Activity and Route should be Route and Activity, would fix that also.

regards, Siebren.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants