Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sets default activity #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sets default activity #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4386b2e
sets default activity
cjakeman Oct 18, 2024
2a7895d
Merge branch 'main' into set-default-activity
cjakeman Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions routes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,18 @@
"screenshot": "https://www.trainsimulations.net/starter",
"url": "https://ts-files.com/files/TS_STARTER_ROUTE.zip",
"downloadSize": 598168814,
"installSize": 894345725
"installSize": 894345725,
"start": {
"route": "BNSF Scenic Sub",
"activity": "1. What Goes Up...",
"locomotive": "BNSF C44-9W 4870",
"consist": "BNSF Intermodal (60 cars)",
"startingat": "Skykomish",
"headingto": "Berne",
"time": "12:00",
"season": "Winter",
"weather": "Snow"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this stuff below activity necessary? Can it override the activity or is it only going to cause confusion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ok with or without. Values do not get overwritten. Could be confusing when somehow one of the extra items get changed in the downloaded route (highly unlikable).

However the info webpage shows empty strings when left out from the routes.json:

Start options:

  • Installation profile: BNSF Starter Route
  • Activity: 1. What Goes Up...
  • Route: BNSF Scenic Sub
  • Locomotive:
  • Consist:
  • Starting at:
  • Heading to:
  • Time:
  • Season:
  • Weather:

I would suggest removing the extra fields from routes.json, it is redundant information anyway. And let me add an extra if in the code generating the info webpage. And on this webpage the lines Activity and Route should be Route and Activity, would fix that also.

regards, Siebren.

}
},
{
"@type": "https://schema.org/SoftwareApplication",
Expand Down Expand Up @@ -91,7 +102,7 @@
"installSize": 311382016,
"start": {
"route": "Scottish Capital Express",
"activity": "+ Explore in Activity Mode +",
"activity": "0930 Edinburgh-Glasgow Queen Street",
"locomotive": "MT Class 27 27102 BR Blue",
"consist": "MT Class 27 102 & 6 mk2 PP",
"startingat": "Edinburgh",
Expand Down