-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding task cancellation timestamp in task API #7445
Conversation
Signed-off-by: Sagar Upadhyaya <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sagar Upadhyaya <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7445 +/- ##
===========================================
+ Coverage 0 70.72% +70.72%
- Complexity 0 56132 +56132
===========================================
Files 0 4680 +4680
Lines 0 266104 +266104
Branches 0 39070 +39070
===========================================
+ Hits 0 188192 +188192
- Misses 0 61938 +61938
- Partials 0 15974 +15974
|
Signed-off-by: Sagar Upadhyaya <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Otherwise LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment. Otherwise LGTM
@dblock Can you take a look? I think the thing you requested changes on has been addressed. |
Signed-off-by: Sagar <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's walk back from suggestions and help this PR get in. What are your must haves @Bukhtawar @andrross?
@dblock Personally I'm fine with it as-is. Just waiting on resolving your request changes :) I do think the |
No strong opinion from my side as well. There is only a small overhead of the non-primitive |
Gradle Check (Jenkins) Run Completed with:
|
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit 8d7a544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Adding task cancellation timestamp in task API (#7445) * Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit 8d7a544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Changing version guard to 2.8 Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrew Ross <[email protected]>
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Adding task cancellation start time and running time since cancellation details as discussed here - #6953
Related Issues
Partially resolves - #6953
Manual testing
Spun up an opensearch cluster and added deliberate delay in search request via sleep to mock and test this functionality.
Without cancellation
After cancellation parent Search Task
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.