Remove Comparator and Jupyter since it will be replaced by OTEL and Analytics Engine #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalytics Engine Signed-off-by: Brian Presley <[email protected]>
Signed-off-by: Brian Presley <[email protected]>
sumobrian
requested review from
chelma,
gregschohn,
kartg,
lewijacn,
mikaylathompson and
okhasawn
as code owners
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
============================================
+ Coverage 60.41% 60.43% +0.01%
+ Complexity 673 670 -3
============================================
Files 78 78
Lines 3241 3235 -6
Branches 300 299 -1
============================================
- Hits 1958 1955 -3
+ Misses 1087 1084 -3
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -101,7 +47,7 @@ javaContainerServices.each { projectName, dockerImageName -> | |||
| CommonUtils.createDockerfile(project, projectName, baseImageProjectOverrides, dockerFilesForExternalServices) | |||
| } | |||
|
|
|||
| (javaContainerServices + trafficComparatorServices).forEach { projectName, dockerImageName -> | |||
| (javaContainerServices).forEach { projectName, dockerImageName -> | |||
There was a problem hiding this comment.
very minor, but the parens here are now unnecessary
gregschohn
reviewed
Nov 12, 2023
| @@ -58,7 +58,7 @@ public class HttpJsonTransformingConsumer<R> implements IPacketFinalizingConsume | |||
| private final List<List<Integer>> chunkSizes; | |||
| // This is here for recovery, in case anything goes wrong with a transformation & we want to | |||
| // just dump it directly. Notice that we're already storing all of the bytes until the response | |||
| // comes back so that we can format the output that goes to the comparator. These should be | |||
| // comes back so that we can format the output. These should be | |||
There was a problem hiding this comment.
reformat to not make it look like you deleted something :)
Signed-off-by: Brian Presley <[email protected]>
Signed-off-by: Brian Presley <[email protected]>
Signed-off-by: Brian Presley <[email protected]>
sumobrian
force-pushed
the
remove_jupyter_and_comparator
branch
from
22822d8
to
0de0a3e
Compare
gregschohn
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing references to Comparator and Jupyter in the project. Future builds should exclude these containers and stacks. This pull request can serve as a resource for future projects involving Comparator. We will apply our insights to improve comparison processes using OpenTelemetry and an analytics engine. This approach aims to generate visualizations and tools for evaluating updates, migrations, or comparisons more effectively.
Testing
Verified no unit tests were broken.
Verified Docker Solution end-to-end test using OpenSearch benchmarks ran as expected.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.