Disable join types in validators #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
…ange Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
disable_join_types
branch
from
7e897d3
to
36858e3
Compare
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
LantaoJin and
noCharger
as code owners
dai-chen
reviewed
Oct 7, 2024
Comment on lines
+58
to
+62
| CROSS_JOIN, | ||
| LEFT_SEMI_JOIN, | ||
| RIGHT_OUTER_JOIN, | ||
| FULL_OUTER_JOIN, | ||
| LEFT_ANTI_JOIN, |
There was a problem hiding this comment.
These JOIN types are disallowed even for S3 data source?
There was a problem hiding this comment.
Yes, limiting regardless of the data source.
There was a problem hiding this comment.
So we only limit these JOIN types due to performance/cost? Others like INNER JOIN, LEFT JOIN can still work?
There was a problem hiding this comment.
Yes, intention is only allowing INNER JOIN and LEFT OUTER JOIN.
7 tasks
dai-chen
approved these changes
Oct 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Disable join types in validators Signed-off-by: Tomoyuki Morita <[email protected]> * Removed methods from SQLQueryValidationVisitor due to grammar file change Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit ac8678c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Disable join types in validators * Removed methods from SQLQueryValidationVisitor due to grammar file change --------- (cherry picked from commit ac8678c) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: Implement SQL validation based on grammar element #3039
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.