Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-14780: fix ptp templates #2062

Merged

Conversation

edcdavid
Copy link
Contributor

@edcdavid edcdavid commented Oct 4, 2024

This is to fix a typo in ptp templates using interface ens6f0 instead of interface enf5f0 and phc2sysOpts: "-a -r -n 25" instead of phc2sysOpts: "-a -r -n 24"

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 4, 2024
@openshift-ci-robot
Copy link
Collaborator

@edcdavid: This pull request references CNF-14780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to this:

This is to fix a typo in ptp templates using interface ens6f0 instead of interface enf5f0 and phc2sysOpts: "-a -r -n 25" instead of phc2sysOpts: "-a -r -n 24"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edcdavid, imiller0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2dbbb92 into openshift-kni:master Oct 4, 2024
5 of 6 checks passed
@edcdavid
Copy link
Contributor Author

edcdavid commented Oct 7, 2024

/cherrypick release-4.17

@openshift-cherrypick-robot

@edcdavid: new pull request created: #2063

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants