Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] CNF-14780: fix ptp templates #2063

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] CNF-14780: fix ptp templates #2063

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2062

/assign edcdavid

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2024
Merged
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNF-14780

In response to this:

This is an automated cherry-pick of #2062

/assign edcdavid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

imiller0
imiller0 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imiller0, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@imiller0
Copy link
Contributor

imiller0 commented Oct 7, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@imiller0
Copy link
Contributor

imiller0 commented Oct 7, 2024

@edcdavid please fix the bug references (add to the title) so that there is proper bug tracking with these backport PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imiller0 imiller0 imiller0 approved these changes

@fedepaol fedepaol Awaiting requested review from fedepaol

@vitus133 vitus133 Awaiting requested review from vitus133

Assignees

@imiller0 imiller0

@edcdavid edcdavid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @imiller0 @edcdavid