Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backbone-router] add Backbone multicast routing #532

Merged
merged 2 commits into from
Oct 28, 2020

Conversation

simonlingoogle
Copy link
Member

@simonlingoogle simonlingoogle commented Aug 4, 2020

This PR uses smcroute to implement multicast forwarding for MLR Listeners.

Major changes include:

Suggested merge steps: @jwhui

  1. Merge [scripts] add MLR Backbone multicast routing test openthread#5578 using latest commit of this PR, passing all checks
  2. Merge this PR using OpenThread master, passing all checks, after [scripts] add MLR Backbone multicast routing test openthread#5578 is merged

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #532 into master will decrease coverage by 0.23%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
- Coverage   76.82%   76.59%   -0.24%     
==========================================
  Files          70       74       +4     
  Lines        4885     4905      +20     
==========================================
+ Hits         3753     3757       +4     
- Misses       1132     1148      +16     
Impacted Files Coverage Δ
src/agent/agent_instance.hpp 100.00% <ø> (ø)
src/agent/border_agent.hpp 100.00% <ø> (ø)
src/agent/ncp.hpp 100.00% <ø> (ø)
src/agent/ncp_openthread.cpp 77.92% <ø> (ø)
src/agent/ncp_openthread.hpp 100.00% <ø> (ø)
src/common/code_utils.hpp 100.00% <ø> (ø)
src/common/logging.cpp 27.27% <ø> (-1.73%) ⬇️
src/common/types.cpp 0.00% <0.00%> (ø)
src/utils/system_utils.cpp 0.00% <0.00%> (ø)
src/agent/agent_instance.cpp 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8609c03...0c66491. Read the comment docs.

@simonlingoogle simonlingoogle marked this pull request as ready for review September 28, 2020 01:51
@google-cla
Copy link

google-cla bot commented Oct 21, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

src/utils/system_utils.hpp Outdated Show resolved Hide resolved
src/utils/system_utils.cpp Outdated Show resolved Hide resolved
@simonlingoogle
Copy link
Member Author

simonlingoogle commented Oct 27, 2020

The raspbian-check is constantly failing:

/usr/bin/ranlib: third_party/openthread/repo/src/core/libopenthread-ftd.a: No space left on device
[278/332] Building C object third_party/http-parser/CMakeFiles/http_parser.dir/repo/http_parser.c.o
FAILED: third_party/http-parser/CMakeFiles/http_parser.dir/repo/http_parser.c.o 
/usr/bin/cc  -I../../third_party/http-parser/repo -g -Wall -Wextra -Werror -Wfatal-errors -Wno-missing-braces -std=gnu99 -MD -MT third_party/http-parser/CMakeFiles/http_parser.dir/repo/http_parser.c.o -MF third_party/http-parser/CMakeFiles/http_parser.dir/repo/http_parser.c.o.d -o third_party/http-parser/CMakeFiles/http_parser.dir/repo/http_parser.c.o -c ../../third_party/http-parser/repo/http_parser.c
../../third_party/http-parser/repo/http_parser.c:2575:1: fatal error: error writing to /tmp/ccgLbYAG.s: No space left on device
 }
 ^
compilation terminated.
[279/332] Building C object third_party/cJSON/repo/CMakeFiles/cjson.dir/cJSON.c.o
FAILED: third_party/cJSON/repo/CMakeFiles/cjson.dir/cJSON.c.o 
/usr/bin/cc -DCJSON_API_VISIBILITY -DCJSON_EXPORT_SYMBOLS -DENABLE_LOCALES -I../../third_party/cJSON/repo -fvisibility=hidden  -g -Wall -Wextra -Werror -Wfatal-errors -Wno-missing-braces -std=gnu99 -MD -MT third_party/cJSON/repo/CMakeFiles/cjson.dir/cJSON.c.o -MF third_party/cJSON/repo/CMakeFiles/cjson.dir/cJSON.c.o.d -o third_party/cJSON/repo/CMakeFiles/cjson.dir/cJSON.c.o -c ../../third_party/cJSON/repo/cJSON.c
../../third_party/cJSON/repo/cJSON.c:3096:1: fatal error: error writing to /tmp/ccoYCJkz.s: No space left on device
 }
 ^
compilation terminated.
ninja: build stopped: subcommand failed.

Any one has a clue? @bukepo @jwhui

The issue is now fixed by ryankurte/docker-rpi-emu#21. Previously we never successfully expanded the raspbian image by 1024MB.
Now all checks are passed.

src/agent/instance_params.cpp Outdated Show resolved Hide resolved
src/agent/instance_params.hpp Outdated Show resolved Hide resolved
src/agent/instance_params.hpp Outdated Show resolved Hide resolved
src/backbone_router/CMakeLists.txt Outdated Show resolved Hide resolved
src/agent/instance_params.cpp Outdated Show resolved Hide resolved
@jwhui jwhui merged commit 693483e into openthread:master Oct 28, 2020
@simonlingoogle simonlingoogle deleted the smcroute branch October 29, 2020 03:03
simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
Bug: 171933690

* origin/github/master:
  [cmake] update OT_LOG_LEVEL for debug build (openthread#582)
  [common] remove client dependency of OpenThread header (openthread#601)
  [web-service] escape networkname (openthread#579)
  [backbone-router] add Backbone multicast routing (openthread#532)
  [docker] add backbone CI dependency (openthread#599)
  [cmake] fix conditional inclusion of REST dependencies (openthread#597)
  [openthread] update to 7a24666 (openthread#596)
  [docker] move to ubuntu 20.04 (openthread#595)
Change-Id: I7570b0245992f3d08d9242a163565d3e417cc241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants