Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Compute tabular data samples at batch creation [WIP] #1510

Closed
wants to merge 92 commits into from

Conversation

ourownstory
Copy link
Owner

@ourownstory ourownstory commented Jan 16, 2024

🔬 Background

🔮 Key changes

  • On the fly sampling of the dataloader

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

@ourownstory ourownstory marked this pull request as draft January 17, 2024 00:46
@ourownstory ourownstory changed the title [Major] Compute tabular data samples at batch creation [Major] Compute tabular data samples at batch creation [WIP] Jan 17, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (305de42) 88.41% compared to head (a6eceb2) 88.13%.

Files Patch % Lines
neuralprophet/time_dataset.py 93.24% 20 Missing ⚠️
neuralprophet/forecaster.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   88.41%   88.13%   -0.29%     
==========================================
  Files          38       38              
  Lines        5103     5115      +12     
==========================================
- Hits         4512     4508       -4     
- Misses        591      607      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drastically increased memory load
2 participants