Workaround for GitHub workflow dropping CentOS7 support #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS7 is old, and GitHub Runner recently uses 'node20' which requires newer GLIBC that does not exist in CentOS7. As a result, the three workflows in our repository that use 'ovis-centos-build' image fails to even checkout the code since `actions/checkout@v3` was implemented in TypeScript that run using 'node.js'. According to this: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ CentOS7 is also removed from the supported OS list due to node20 not supported on CentOS7. This patch does the following on the CentOS7-based workflows: - Use `actions/checkout@v1` (instead of v3) because it is implemented as a plugin that comes with the GitHub Runner (C++). We do not use any advanced features that does not exist in v1. - Remove the use of `actions/upload-artifact`. v3 is implemented in TypeScript, and v1 (C++ Runner Plugin) does not work. The artifact's purpose was for debugging.
|
The pull request is the same patch as #1416 but for b4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS7 is old, and GitHub Runner recently uses 'node20' which requires newer GLIBC that does not exist in CentOS7. As a result, the three workflows in our repository that use 'ovis-centos-build' image fails to even checkout the code since
actions/checkout@v3was implemented in TypeScript that run using 'node.js'.According to this:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/ CentOS7 is also removed from the supported OS list due to node20 not supported on CentOS7.
This patch does the following on the CentOS7-based workflows:
Use
actions/checkout@v1(instead of v3) because it is implemented as a plugin that comes with the GitHub Runner (C++). We do not use any advanced features that does not exist in v1.Remove the use of
actions/upload-artifact. v3 is implemented in TypeScript, and v1 (C++ Runner Plugin) does not work. The artifact's purpose was for debugging.