Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Implement Electrify #4569

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

innerthunder
Copy link
Collaborator

@innerthunder innerthunder commented Oct 4, 2024

What are the changes the user will see?

This implements the move Electrify.

Why am I making these changes?

More implementations are good, and this isn't much different from Plasma Fists, which I just implemented.

What are the changes from a developer perspective?

  • data/battler-tags: New ELECTRIFIED tag converts the tag holder's moves to Electric type for the rest of the turn.
  • data/move: Electrify now uses an AddBattlerTagAttr to add an ELECTRIFIED tag to the target.
  • field/pokemon: getMoveType now returns Type.ELECTRIC when the Pokemon has an ELECTRIFIED tag (this applies after move-type-changing abilities like Pixilate).

Screenshots/Videos

How to test the changes?

npm run test electrify (2 new tests)

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@innerthunder innerthunder marked this pull request as ready for review October 4, 2024 06:41
@innerthunder innerthunder requested a review from a team as a code owner October 4, 2024 06:41
DayKev
DayKev previously approved these changes Oct 4, 2024
src/data/battler-tags.ts Outdated Show resolved Hide resolved
@Tempo-anon Tempo-anon merged commit 2753728 into pagefaultgames:beta Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants