[P2] Fix evolutions unable to strictly apply to base Pokemon forms #4581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
G-Max Pikachu, Eevee, Meowth, and Duraludon should no longer be incorrectly prompted or allowed to evolve.
Why am I making these changes?
Reported on the Discord
What are the changes from a developer perspective?
field/pokemon
:Pokemon#getEvolution
now usesisNullOrUndefined(evo.preFormKey)
instead of!evo.preFormKey
to check if an evolution isn't tied to a specific form. Using!evo.preFormKey
caused issues because the keys for base forms are""
, which is also interpreted as falsy.Screenshots/Videos
How to test the changes?
Easiest way using overrides:
Checklist
beta
as my base branchnpm run test
)