Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2] Fix evolutions unable to strictly apply to base Pokemon forms #4581

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

innerthunder
Copy link
Collaborator

@innerthunder innerthunder commented Oct 4, 2024

What are the changes the user will see?

G-Max Pikachu, Eevee, Meowth, and Duraludon should no longer be incorrectly prompted or allowed to evolve.

Why am I making these changes?

Reported on the Discord

What are the changes from a developer perspective?

field/pokemon: Pokemon#getEvolution now uses isNullOrUndefined(evo.preFormKey) instead of !evo.preFormKey to check if an evolution isn't tied to a specific form. Using !evo.preFormKey caused issues because the keys for base forms are "", which is also interpreted as falsy.

Screenshots/Videos

How to test the changes?

Easiest way using overrides:

  1. Give yourself a Level 28 G-Max Meowth.
  2. Clear a wave. Then, from the rewards screen, give your G-Max Meowth a Rare Candy.
  3. The Meowth should not be prompted to evolve into a Persian.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [?] Are the changes visual?
    • [?] Have I provided screenshots/videos of the changes?

@innerthunder innerthunder requested a review from a team as a code owner October 4, 2024 21:54
@innerthunder innerthunder added P2 Bug Minor. Non crashing Incorrect move/ability/interaction Miscellaneous Changes that don't fit under any other label labels Oct 4, 2024
@Tempo-anon Tempo-anon merged commit f629a3e into pagefaultgames:beta Oct 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants