[Ability Implementation] Implementing Mirror Armor #4769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
NOT READY TO BE MERGED, STILL MANY THINGS TO DO
WILL ADD MORE VIDEOS AS I COMPLETE THIS
This was working with double battles properly with doubles at one point yesterday, but I think I broke something and now
double battles dont work (it doesnt decrease the stats of the proper pokemon)
I added a LOT of tests to account for the simplest situations I came across. The tests dont all work, but hopefully they do when I get around to finishing this ability.
There is some more edges cases that need to be thought of:
Any help would be nice, the code is quite messy imo.
What are the changes the user will see?
Mirror Armor will work as intended in the game
Why am I making these changes?
Adding new gameplay features
What are the changes from a developer perspective?
Had to add new variables to keep track of uses of moves and abilities, added new ability attr, and changed some phase files around.
Screenshots/Videos
2024-10-31.16-15-02.mp4
How to test the changes?
Override Files and unit tests, and debugger in browser
Checklist
beta
as my base branchnpm run test
)