[Move] Corrosive Gas

[muscode13]

Locales PR

What are the changes the user will see?

Corrosive Gas will be usable in game

Why am I making these changes?

Corrosive Gas is currently unimplemented

What are the changes from a developer perspective?

• isNullified, nullify(), removedNullification added to modifier.ts, alongside checks to shouldApply and match. This will nullify the held item and prevent it's effects from working. I thought this would be the best way to simulate Corrosive Gas' taking an item away then returning it at BattleEnd. I believe this can also be used for other unimplemented moves like Embargo and Magic Room in the future
• NullifyHeldItemAttr - applies nullify on a random item modifier. This affect lasts until the end of the turn. It has all the same ability attrs as Knock Off or Incinerate, since Corrosive Gas technically removes the item. After the item is nullified, it isTransferable is set to false, to prevent knocking off, stealing, or corroding an already corroded item.
• In battle-end-phase.ts I remove the nullified status from the item, as well as if it its isTransferable was set to false, it gets reverted to true. Since only transferable items would get nullified, it acts as a guard clause, preventing items that should be set to false getting set to true.
• Finally in battle-scene.ts I added logic to hide the nullified items from the modifierBar

Screenshots/Videos

Basic Flow:

corrosive.mp4

Effect lasts on switch:

switch.mp4

Sticky Hold Interaction:

sticky.mp4

Substitute interaction:

sub.mp4

Untransferable Item interaction:

untransferitems.mp4

Harvest Interaction:

harvest.mp4

How to test the changes?

• Use npm run test corrosive_gas
• Use Corrosive Gas in-game

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?