[Bug] Moved code preventing MBH's transfer to post modifier generation

[frutescens]

What are the changes the user will see?

MBH will no longer be able to be stolen from the opponent.

Why am I making these changes?

Bug report https://discord.com/channels/1125469663833370665/1300228174151680040

What are the changes from a developer perspective?

Code moved down to correct location.

How to test the changes?

Try to steal MBH when generated.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)

[flx-sta]

Except that 1 comment lgtm

[frutescens]

@PigeonBar I think I decided just to stop a potential transfer of MBH at the heart of the code - tryTransferModifier(). Not sure if it leads to other problems though.

[MokaStitcher]

I haven't tested more as I already found issues with the things I tested :(

• Magician allows to steal MBH
• Knock Off allows to knock it off (that can't be intended right?)
• Thief seems to crash the game when the steal chance procs
  nevermind it seems to happen only if we override the opponent held items... These overrides are bad

console


At this point I'm really starting to think adding a stealable attribute for modifiers that is distinct from the transferrable one may be the way to go, rather than adding MBH-specific checks scattered in various places in the code :(

[frutescens]

@MokaStitcher Since there's not much time left, I decided to the code that worked before the October update instead. It's clunky and not elegant but I believe it will do the job.

[MokaStitcher]

should be good enough for now

[DayKev]

At this point I'm really starting to think adding a stealable attribute for modifiers that is distinct from the transferrable one may be the way to go

I've been saying that for a long time. :)