[Move][Beta] Freeze-dry Re-implementation #4874
Merged
+113
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Why am I making these changes?
#4840 making
FreezeDryAttr
fully recalculate Freeze-dry's type effectiveness is not ideal. Moreover, that PR did not match the usual type effectiveness calculations exactly, leading to the bugs described above.What are the changes from a developer perspective?
FreezeDryAttr
now extends a new classVariableMoveTypeChartAttr
that applies type chart changes to each of the target's individual types..edgeCase()
tag regarding Freeze-Dry's interaction with Tera Shell, since this interaction works correctly. Also added a test for the Tera Shell interaction.@geeilhan Sorry for undoing your hard work. You tried your best, and we truly appreciate your work.
Screenshots/Videos
Before the changes: Freeze-dry is 1x effective against Empoleon affected by Forest's Curse
20241114.Before.Fix.Forests.Curse.mp4
After the changes: Freeze-dry is 2x effective against Empoleon affected by Forest's Curse
20241114.After.Fix.Forests.Curse.mp4
Before the changes: Freeze-dry is 1x effective against Tera-Water Camerupt
20241114.Before.Fix.Tera.mp4
After the changes: Freeze-dry is 2x effective against Tera-Water Camerupt
20241114.After.Fix.Tera.mp4
After the changes: Freeze-dry is still 0.5x effective against Tera Shell
20241114.Tera.Shell.mp4
How to test the changes?
npm run test freeze_dry
Checklist
beta
as my base branch[ ] If I have text, did I make it translatable and add a key in the English locale file(s)?npm run test
)