Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Skip flaky offset test case on WASM #60186

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

mroeschke
Copy link
Member

e.g. https://github.com/pandas-dev/pandas/actions/runs/11661309317/job/32465371369

Not sure why this case is failing only on WASM, but IMO let's just skip this narrow case to get a clearer green signal

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail labels Nov 4, 2024
@mroeschke mroeschke added this to the 2.3 milestone Nov 4, 2024
@jorisvandenbossche
Copy link
Member

Can we reproduce the case with a non-hypothesis written out test case? (or extract that from the failure logs using reproduce_failure>)
Because it might still be worth keeping track of it somewhere in case someone has time to look into it or knows more about it.

But agreed to skip this for now to get green CI.

@@ -28,6 +32,15 @@
@given(DATETIME_JAN_1_1900_OPTIONAL_TZ, YQM_OFFSET)
def test_on_offset_implementations(dt, offset):
assume(not offset.normalize)
# This case is flaky in CI 2024-11-04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ideally open an issue about it with the reproducer and add a link to that issue here?

@mroeschke
Copy link
Member Author

Opened up #60205 to track this failure. I wasn't able to locally reproduce this on OSX.

(I suspect that for the Pyodide build we should install tzdata and avoid having the build look at the system timezone)

@mroeschke mroeschke merged commit eea95a3 into pandas-dev:main Nov 6, 2024
50 of 51 checks passed
@mroeschke mroeschke deleted the tst/flaky/offset branch November 6, 2024 00:26
Copy link

lumberbot-app bot commented Nov 6, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 eea95a304795d5c0e72494a645af417e0449bc9f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60186: TST: Skip flaky offset test case on WASM'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60186-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60186 on branch 2.3.x (TST: Skip flaky offset test case on WASM)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Unreliable Test Unit tests that occasionally fail
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants