-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Skip flaky offset test case on WASM #60186
Conversation
Can we reproduce the case with a non-hypothesis written out test case? (or extract that from the failure logs using But agreed to skip this for now to get green CI. |
@@ -28,6 +32,15 @@ | |||
@given(DATETIME_JAN_1_1900_OPTIONAL_TZ, YQM_OFFSET) | |||
def test_on_offset_implementations(dt, offset): | |||
assume(not offset.normalize) | |||
# This case is flaky in CI 2024-11-04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ideally open an issue about it with the reproducer and add a link to that issue here?
Opened up #60205 to track this failure. I wasn't able to locally reproduce this on OSX. (I suspect that for the Pyodide build we should install |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
e.g. https://github.com/pandas-dev/pandas/actions/runs/11661309317/job/32465371369
Not sure why this case is failing only on WASM, but IMO let's just skip this narrow case to get a clearer green signal