Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Skip flaky offset test case on WASM #60186

Merged
merged 7 commits into from
Nov 6, 2024
Merged

TST: Skip flaky offset test case on WASM #60186

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
36d2e98
TST: Skip flaky offset test case on WASM
mroeschke Nov 4, 2024
418a94a
Check tzinfo exists
mroeschke Nov 4, 2024
350ff72
Check for zoneinfo directly
mroeschke Nov 4, 2024
5bc7272
Undo original change
mroeschke Nov 5, 2024
6698cd5
Try installing tzdata to fix
mroeschke Nov 5, 2024
ec0ae7c
Revert "Try installing tzdata to fix"
mroeschke Nov 5, 2024
1ff7895
Revert "Undo original change"
mroeschke Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pandas/tests/tseries/offsets/test_offsets_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,16 @@
tests, or when trying to pin down the bugs exposed by the tests below.
"""

import zoneinfo

from hypothesis import (
assume,
given,
)
import pytest

from pandas.compat import WASM

import pandas as pd
from pandas._testing._hypothesis import (
DATETIME_JAN_1_1900_OPTIONAL_TZ,
Expand All @@ -28,6 +32,15 @@
@given(DATETIME_JAN_1_1900_OPTIONAL_TZ, YQM_OFFSET)
def test_on_offset_implementations(dt, offset):
assume(not offset.normalize)
# This case is flaky in CI 2024-11-04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ideally open an issue about it with the reproducer and add a link to that issue here?

assume(
not (
WASM
and isinstance(dt.tzinfo, zoneinfo.ZoneInfo)
and dt.tzinfo.key == "Indian/Cocos"
and isinstance(offset, pd.offsets.MonthBegin)
)
)
# check that the class-specific implementations of is_on_offset match
# the general case definition:
# (dt + offset) - offset == dt
Expand Down