Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(evm, trie): more metrics #11613

Merged
merged 8 commits into from
Oct 10, 2024
Merged

feat(evm, trie): more metrics #11613

merged 8 commits into from
Oct 10, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Oct 9, 2024 •
edited
Loading

Partially addresses #11171

In next PRs:

  • Histogram of duration of storage root computation
  • Update Grafana dashboard

@shekhirin shekhirin added C-enhancement New feature or request A-execution Related to the Execution and EVM A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation labels Oct 9, 2024
@shekhirin shekhirin marked this pull request as ready for review October 9, 2024 15:46
@shekhirin shekhirin force-pushed the alexey/evm-state-root-metrics branch from 65d7a94 to bad4fd6 Compare October 9, 2024 16:08
rkrasiuk
rkrasiuk reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, few comments

crates/evm/src/metrics.rs Outdated Show resolved Hide resolved
crates/evm/src/metrics.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin force-pushed the alexey/evm-state-root-metrics branch from 4b834c5 to e9211e8 Compare October 10, 2024 08:08
rkrasiuk
rkrasiuk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shekhirin shekhirin added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 58bfa60 Oct 10, 2024
37 checks passed
@shekhirin shekhirin deleted the alexey/evm-state-root-metrics branch October 10, 2024 08:42
@rkrasiuk rkrasiuk mentioned this pull request Oct 10, 2024
Open
vandenbogart pushed a commit to testmachine-ai/reth that referenced this pull request Oct 14, 2024
@shekhirin
feat(evm, trie): more metrics (paradigmxyz#11613)
cbe6940
reymom pushed a commit to reymom/reth that referenced this pull request Oct 15, 2024
@shekhirin @reymom
feat(evm, trie): more metrics (paradigmxyz#11613)
c27242e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk