-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/pdutils: retry when encountered dns error #53005
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: hillium <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #53005 +/- ##
================================================
Coverage ? 73.6561%
================================================
Files ? 1096
Lines ? 351631
Branches ? 0
================================================
Hits ? 258998
Misses ? 76005
Partials ? 16628 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
close pingcap#53029 Signed-off-by: hillium <[email protected]>
) close pingcap#53029 Co-authored-by: 山岚 <[email protected]>
/run-cherry-picker |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
close pingcap#53029 Signed-off-by: hillium <[email protected]>
What problem does this PR solve?
Issue Number: close #53029
Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses
No such host
which will abort the creation ofPDController
. We should retry this sort of error.What changed and how does it work?
This PR added retry when the
net.Error
isDNSError
.Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.