Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/pdutils: retry when encountered dns error #53005

Merged
merged 3 commits into from
May 6, 2024

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Apr 30, 2024

What problem does this PR solve?

Issue Number: close #53029

Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses No such host which will abort the creation of PDController. We should retry this sort of error.

What changed and how does it work?

This PR added retry when the net.Error is DNSError.
Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
Copy link

tiprow bot commented Apr 30, 2024

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.5@727a2c7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #53005   +/-   ##
================================================
  Coverage               ?   73.6561%           
================================================
  Files                  ?       1096           
  Lines                  ?     351631           
  Branches               ?          0           
================================================
  Hits                   ?     258998           
  Misses                 ?      76005           
  Partials               ?      16628           

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 6, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label May 6, 2024
Copy link

ti-chi-bot bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 6, 2024
Copy link

ti-chi-bot bot commented May 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-06 06:44:11.077720567 +0000 UTC m=+858004.834856132: ☑️ agreed by BornChanger.
  • 2024-05-06 07:17:53.022825179 +0000 UTC m=+860026.779960744: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit fe6837a into pingcap:release-6.5 May 6, 2024
32 of 33 checks passed
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request May 6, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 6, 2024
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
@YuJuncen YuJuncen added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 8, 2024
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Nov 8, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57245.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 8, 2024
YuJuncen added a commit to YuJuncen/tidb that referenced this pull request Nov 8, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants