Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/pdutils: retry when encountered dns error (#53005) #57245

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53005

What problem does this PR solve?

Issue Number: close #53029

Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses No such host which will abort the creation of PDController. We should retry this sort of error.

What changed and how does it work?

This PR added retry when the net.Error is DNSError.
Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Nov 8, 2024
Signed-off-by: hillium <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 8, 2024
Copy link

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2024
Copy link

ti-chi-bot bot commented Nov 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-08 10:02:21.296845328 +0000 UTC m=+4903.487714327: ☑️ agreed by YuJuncen.
  • 2024-11-08 10:09:07.111136418 +0000 UTC m=+5309.302005424: ☑️ agreed by Leavrth.

@hawkingrei
Copy link
Member

/retest

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.1@8829b96). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #57245   +/-   ##
================================================
  Coverage               ?   73.4760%           
================================================
  Files                  ?       1212           
  Lines                  ?     381240           
  Branches               ?          0           
================================================
  Hits                   ?     280120           
  Misses                 ?      83232           
  Partials               ?      17888           

@ti-chi-bot ti-chi-bot bot merged commit 52171ad into pingcap:release-7.1 Nov 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants