-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/pdutils: retry when encountered dns error (#53005) #57245
br/pdutils: retry when encountered dns error (#53005) #57245
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: hillium <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #57245 +/- ##
================================================
Coverage ? 73.4760%
================================================
Files ? 1212
Lines ? 381240
Branches ? 0
================================================
Hits ? 280120
Misses ? 83232
Partials ? 17888 |
This is an automated cherry-pick of #53005
What problem does this PR solve?
Issue Number: close #53029
Problem Summary:
In a tidb-operator deployed cluster, sometimes coredns responses
No such host
which will abort the creation ofPDController
. We should retry this sort of error.What changed and how does it work?
This PR added retry when the
net.Error
isDNSError
.Also, this PR increases the retry time limit from 10 times (totally 10s) to 120 times (totally 120s).
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.