Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: social icon for link #601

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: social icon for link #601

wants to merge 4 commits into from

Conversation

aagjalpankaj
Copy link
Contributor

@aagjalpankaj aagjalpankaj commented Sep 11, 2024 •
edited
Loading

image

@aagjalpankaj aagjalpankaj marked this pull request as draft September 11, 2024 21:14
@aagjalpankaj
Copy link
Contributor Author

@nunomaduro / @MrPunyapal
This is a draft MR for displaying social icons on links. Will this be a significant feature? If so, I'll complete the remaining things and finalize the MR. Do you have any thoughts or suggestions?

@aagjalpankaj aagjalpankaj mentioned this pull request Sep 11, 2024
Open
@aagjalpankaj
Copy link
Contributor Author

@nunomaduro / @MrPunyapal 👆🏼

@aagjalpankaj aagjalpankaj marked this pull request as ready for review September 19, 2024 19:05
@aagjalpankaj
Copy link
Contributor Author

@nunomaduro / @MrPunyapal any thoughts or suggestions?

@MrPunyapal
Copy link
Collaborator

Maybe in future? 🤔

@aagjalpankaj
Copy link
Contributor Author

Okay!
We can also add a setting (toggle) in the section below to let the user decide whether they want to show these icons or not. By default, this toggle can be off.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aagjalpankaj @MrPunyapal