Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection outline #221

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Add selection outline #221

merged 9 commits into from
Oct 22, 2024

Conversation

slimbuck
Copy link
Member

This PR adds the option to show the current selection as an outline. This can be useful when moving splats in a scene.

In addition, the following changes were made:

  • extract shaders into their own modules
  • fixed a bound calculation bug which resulted in local bound always including (0, 0, 0)
Screen.Recording.2024-10-21.at.15.00.51.mov

@slimbuck slimbuck added the enhancement New feature label Oct 21, 2024
@slimbuck slimbuck requested a review from a team October 21, 2024 14:04
@slimbuck slimbuck self-assigned this Oct 21, 2024
@slimbuck slimbuck merged commit 1b1ad09 into playcanvas:main Oct 22, 2024
2 checks passed
@slimbuck slimbuck deleted the outline-dev branch October 22, 2024 10:01
@slimbuck slimbuck mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @willeastcott